Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Use Alpine Linux in WSL on CI#1945

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
Byron merged 2 commits intogitpython-developers:mainfromEliahKagan:wsl-alpine
Jul 24, 2024

Conversation

EliahKagan
Copy link
Member

@EliahKaganEliahKagan commentedJul 24, 2024
edited
Loading

Some of the CI tests use WSL. This switches the WSL distribution from Debian to Alpine, which might be slightly faster. For the way it is being used here, the main expected speed improvement would be to how long the image would take to download*, as Alpine is smaller.

(The reason for this is thus unrelated to the reason for the Alpine docker CI test job added in#1826. There, the goal was to test on a wider variety of systems and environments, and that runs the whole test suite in Alpine. This just changes the WSL distro, used by a few tests on Windows, from Debian to Alpine.)

Two things have changed that, taken together, have unblocked this:


* Alpine Linux doesn't ship withbash so this has thesetup-wsl action install thebash package. Updating package indexes and installing the package in the WSL system adds to the overhead. It is still much faster to set up than Debian... except that obtaining the Alpine Linux image, even though it is smaller than the Debian image, tends to take longer, because it is not available from as fast of a source. This relates toVampire/setup-wsl#50 (comment); the issue there was about the action not being able to download from the second source at all, which was fixed.

The effect is that Alpine Linux takes longer to download from outside of GitHub, but is faster to retrieve from the GitHub Actions cache and install. Looking at the total time difference added up from all six Windows jobs that use it, this change does slightly better than with Debian. But the slight increase in complexity would likely make it unjustified given the mixed returns. But that's on the feature branch. I believe the cached download will be reusable across separate workflow runs if this is merged, so I would expect a significant overall improvement, with a total time spent getting WSL set up decreased well under half the original total time. So I think it's probably justified.

This is subjective and I will not be sad if you choose to close this without merging.

Some of the CI tests use WSL. This switches the WSL distributionfrom Debian to Alpine, which might be slightly faster. For the wayit is being used here, the main expected speed improvement would beto how long the image would take to download, as Alpine is smaller.(The reason for this is thus unrelated to the reason for the Alpinedocker CI test job added ingitpython-developers#1826. There, the goal was to test on awider variety of systems and environments, and that runs the wholetest suite in Alpine. This just changes the WSL distro, used by afew tests on Windows, from Debian to Alpine.)Two things have changed that, taken together, have unblocked this:-Vampire/setup-wsl#50 was fixed, so the  action we are using is able to install Alpine Linux. See:gitpython-developers#1917 (review)-gitpython-developers#1893 was fixed ingitpython-developers#1888. So if switching the WSL distro from  Debian to Alpine breaks any tests, including by making them fail  in an unexpected way that raises the wrong exception, we are  likely to find out.
Because Alpine Linux does not ship with bash, and the tests thatuse WSL use it.
@EliahKaganEliahKagan marked this pull request as ready for reviewJuly 24, 2024 07:41
Copy link
Member

@ByronByron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks a lot being on top of this!

Let's merge and see if we are lucky with compile-time improvements due to effective GitHub CI caching.

EliahKagan reacted with thumbs up emoji
@ByronByron merged commit0b81749 intogitpython-developers:mainJul 24, 2024
26 checks passed
@EliahKaganEliahKagan deleted the wsl-alpine branchJuly 24, 2024 08:29
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@ByronByronByron approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@EliahKagan@Byron

[8]ページ先頭

©2009-2025 Movatter.jp