Movatterモバイル変換

Skip to content

gitpython-developers/GitPythonPublic

NotificationsYou must be signed in to change notification settings
Fork938
Star4.9k

typing fixes - DiffIndex generic type and IndexFile items#1925

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Byron merged 2 commits intogitpython-developers:mainfromAndrej730:main

Jun 3, 2024

Merged

typing fixes - DiffIndex generic type and IndexFile items#1925

Byron merged 2 commits intogitpython-developers:mainfromAndrej730:main

Jun 3, 2024

Conversation

Andrej730

Copy link

Contributor

Andrej730 commentedJun 2, 2024

Example issue with DiffIndex:

repo=git.Repo(path_dir)diff=repo.index.diff(None)modified_files= [dfordinrepo.index.diff(None)]reveal_type(modified_files)# list[Unknown] instead of list[Diff]

Example issue with IndexFile:

path:os.PathLike= ...repo=git.Repo(path_dir)# Argument of type "PathLike[Unknown]"# cannot be assigned to parameter "items" of type "Sequence[git.types.PathLike | Blob | BaseIndexEntry | Submodule]" in function "add"# "PathLike[Unknown]" is incompatible with "Sequence[git.types.PathLike | Blob | BaseIndexEntry | Submodule]"repo.index.add(path)

Andrej730 added2 commits

June 3, 2024 00:32

@Andrej730

Fix IndexFile items argument type

59a0c88

Error before commit:path: os.PathLike = ...repo = git.Repo(path_dir)repo.index.add(path)

@Andrej730

Specify DiffIndex generic type

77fb5f0

Example before this commit:repo = git.Repo(path_dir)diff = repo.index.diff(None)modified_files = [d for d in repo.index.diff(None)]reveal_type(modified_files) # list[Unknown] instead of list[Diff]

Byron

Byron approved these changes

View reviewed changes

Copy link

Member

Byron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks a lot for the typing fix, it's much appreciated.

@Byron

Byron merged commite51bfdf intogitpython-developers:main

26 checks passed

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Labels

None yet

2 participants

@Andrej730

@Byron

[8]ページ先頭

©2009-2025 Movatter.jp