Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork938
Bump Vampire/setup-wsl from 3.0.0 to 3.1.0#1917
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Bumps [Vampire/setup-wsl](https://github.com/vampire/setup-wsl) from 3.0.0 to 3.1.0.- [Release notes](https://github.com/vampire/setup-wsl/releases)- [Commits](Vampire/setup-wsl@v3.0.0...v3.1.0)---updated-dependencies:- dependency-name: Vampire/setup-wsl dependency-type: direct:production update-type: version-update:semver-minor...Signed-off-by: dependabot[bot] <support@github.com>
EliahKagan commentedMay 27, 2024 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
There appear to be two separate kinds of failures here. The failure withPython 3.7 on Ubuntu appears to be a result of a corrupted download, which should resolve if re-run. In contrast, it seems the failures on Windows always occur with that step, as written, to install Debian, at least on Although we should probably wait for feedback onVampire/setup-wsl#58 (and possibly a fix) before attempting further steps toward bringing in the changes from this PR, I suggest rerunningall It may not be strictly necessary to do so, since I have madea branch in my fork from this branch here, whose CIdoes behave that way. But rerunning them all here should give slightly greater confidence and, perhaps more importantly, should make it clearer, when we (or others, perhaps to fix the issue) look at this later, which test jobs fail consistently. |
Vampire commentedMay 27, 2024
The setup-wsl problem should be fixed in 3.1.1, sorry |
Uh oh!
There was an error while loading.Please reload this page.
@Vampire That's great, thanks!! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM. It is working since 3.1.1 was released and this was further bumped to it, so I think this can be merged.
Although Dependabot could be made to redo the version update in which case the PR title its commit message would have 3.1.1-specific links, I think that's not necessary and the manual bump, as already done here, is sufficient. The commit history will make clear that the action was upgraded to 3.1.1. (If you do want to do that, I think just having Dependabot redo the version update scan with the "Check for updates" button in "Recent update jobs" would be sufficient; I believe that would cause Dependabot to close this PR and open another one. I emphasize that I amnot requesting this.)
Some subsequent changes may make sense, such as changing Debian to Alpine. As discussed in#1745, this was waiting onVampire/setup-wsl#50, which is now fixed. However, since the value of upgrading is not contingent on that, I recommend merging this PR first. Afterwards, I can experiment with and, if it seems helpful, open a PR to change Debian to Alpine.
14066e2 intomainUh oh!
There was an error while loading.Please reload this page.
Thanks everyone! I went ahead and just merged this PR, and hope it helps. |
Some of the CI tests use WSL. This switches the WSL distributionfrom Debian to Alpine, which might be slightly faster. For the wayit is being used here, the main expected speed improvement would beto how long the image would take to download, as Alpine is smaller.(The reason for this is thus unrelated to the reason for the Alpinedocker CI test job added ingitpython-developers#1826. There, the goal was to test on awider variety of systems and environments, and that runs the wholetest suite in Alpine. This just changes the WSL distro, used by afew tests on Windows, from Debian to Alpine.)Two things have changed that, taken together, have unblocked this:-Vampire/setup-wsl#50 was fixed, so the action we are using is able to install Alpine Linux. See:gitpython-developers#1917 (review)-gitpython-developers#1893 was fixed ingitpython-developers#1888. So if switching the WSL distro from Debian to Alpine breaks any tests, including by making them fail in an unexpected way that raises the wrong exception, we are likely to find out.
BumpsVampire/setup-wsl from 3.0.0 to 3.1.0.
Release notes
Sourced fromVampire/setup-wsl's releases.
Commits
45f5a8c[Gradle Release Plugin] - pre tag commit: 'v3.1.0'.b7c49fbAdd a warning about /etc/wsl.conf being overwrittend29d157Make test_distribution_specific_wsl_bash_scripts names uniquea2f462bAdd support for Ubuntu 24.04 (#57)9be6f77Increase version to 3.1.0d81efaeLog contents of /etc/wsl.conf if it exists unexpectedly00dc521Refactor test workflow scripte5717e2Make procuctId to URL translation work again (#50)a6c8b14Work around KT-42101 when preprocessing workflowsa5e8694Add debug logging if the product ID could not be resolved to a download URLDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)