Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Add GitPython's Standard License Header Comments to Shell Scripts#1907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

DaveLak
Copy link
Contributor

This is related to follow-ups for unresolved review comments in#1901. Specifically:#1901 (comment)

See the commit messages for2b0a969 andb021a76 for further details.

CC@EliahKagan for visibility

These files are already BSD-3-Clause even without the headers, butadding these comments and the `LICENSE-BSD` symlink to the root level`LICENSE` file are helpful to reinforce that there are only twoparticular files in the `fuzzing/` that are not under BSD-3-Clause.See:gitpython-developers#1901 (comment)
While discussing adding similar license comments to the shell scriptsintroduced in PRgitpython-developers#1901, it was noticed that the shell scripts in therepository root directory did not have such comments and suggested thatwe could add them when the scripts in the `fuzzing/` directory wereupdated, so this commit does just that.See:gitpython-developers#1901 (comment)
@DaveLakDaveLak mentioned this pull requestApr 22, 2024
11 tasks
Copy link
Member

@EliahKaganEliahKagan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM

DaveLak reacted with thumbs up emoji
Copy link
Member

@ByronByron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Great, thank you!

@ByronByron merged commitfa2b2d6 intogitpython-developers:mainApr 23, 2024
26 checks passed
@DaveLakDaveLak deleted the add-license-header-comments-to-shell-scripts branchApril 29, 2024 00:34
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@ByronByronByron approved these changes

@EliahKaganEliahKaganEliahKagan approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@DaveLak@Byron@EliahKagan

[8]ページ先頭

©2009-2025 Movatter.jp