Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork947
Add GitPython's Standard License Header Comments to Shell Scripts#1907
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Byron merged 2 commits intogitpython-developers:mainfromDaveLak:add-license-header-comments-to-shell-scriptsApr 23, 2024
Merged
Add GitPython's Standard License Header Comments to Shell Scripts#1907
Byron merged 2 commits intogitpython-developers:mainfromDaveLak:add-license-header-comments-to-shell-scriptsApr 23, 2024
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
These files are already BSD-3-Clause even without the headers, butadding these comments and the `LICENSE-BSD` symlink to the root level`LICENSE` file are helpful to reinforce that there are only twoparticular files in the `fuzzing/` that are not under BSD-3-Clause.See:gitpython-developers#1901 (comment)
While discussing adding similar license comments to the shell scriptsintroduced in PRgitpython-developers#1901, it was noticed that the shell scripts in therepository root directory did not have such comments and suggested thatwe could add them when the scripts in the `fuzzing/` directory wereupdated, so this commit does just that.See:gitpython-developers#1901 (comment)
EliahKagan approved these changesApr 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM
Byron approved these changesApr 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Great, thank you!
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is related to follow-ups for unresolved review comments in#1901. Specifically:#1901 (comment)
See the commit messages for2b0a969 andb021a76 for further details.
CC@EliahKagan for visibility