Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork938
Fixed an error updating shallow submodules#1899
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Fixed the error of updating shallow submodules
Do these numbers in |
I don't think so. I've found this number only in one branch. Other branches didn't have this number. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thank you.
The new regex would unconditionally consume up to three characters, just as long as there is one more to capture, followed by a space.
Thisshould be safe and handle this particular case.
When we try to execute
submodule_update(recursive=True, init=True)
in Repo class with shallow submodules, command
git fetch --progress -v origin
sometimes print log such as
=5 = [up to date] zm/160_uwp -> origin/zm/160_uwp
but it doesn't satisfy filter:
r"^(.) ([[\w .$@]+]|[\w.$@]+) +(.+) -> ([^ ]+)( (.)?$)?"
and throw exception.
I've updated it so that it works correctly.