Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

lint: replaceflake8 withruff check#1862

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
Byron merged 3 commits intogitpython-developers:mainfromBorda:lint/ruff
Mar 11, 2024

Conversation

Borda
Copy link
Contributor

Resolves#1861

@Borda
Copy link
ContributorAuthor

this is still missing

rst-roles =  # for flake8-RST-docstrings    attr, class, func, meth, mod, obj, ref, term, var  # used by sphinx

and I would suggest replacing it withhttps://github.com/rstcheck/rstcheck#examples

@Byron
Copy link
Member

Thanks a lot for tackling this! Maybe@EliahKagan can also have a look.

@Borda
Copy link
ContributorAuthor

For the Literal issue we may need to import directlyastral-sh/ruff#128 (comment)

EliahKagan reacted with thumbs up emoji

@BordaBorda marked this pull request as ready for reviewMarch 11, 2024 10:18
@Borda
Copy link
ContributorAuthor

@Byron could you pls help me to understand why thepytest is failing which seems to me as unrelated?

@Byron
Copy link
Member

Happily!

I restarted the runs and it looks like they will be passing now - probably something wrong with the runner/bad luck. It's quite rare, fortunately, so I'd expect this to not happen again.

@Borda
Copy link
ContributorAuthor

I restarted the runs and it looks like they will be passing now - probably something wrong with the runner/bad luck. It's quite rare, fortunately, so I'd expect this to not happen again.

thank you, there is still one more, it is possible it a flaky test?

FAILED test/test_installation.py::TestInstallation::test_installation - AssertionError: 0 != 2 : b'Processing /cygdrive/d/a/GitPython/GitPython\n'

@Byron
Copy link
Member

Oh, I was declaring victory too early, sorry for that. This looks like a real failure then, but I don't know how that would be related. Would your changes affect the GitPython installation on Cygwin?

@Borda
Copy link
ContributorAuthor

Would your changes affect the GitPython installation on Cygwin?

revisiting the change again and except the import Literal I did not not any code change

@Byron
Copy link
Member

It looks real, but I don't know what it is about. Maybe ignore it for now until there is another PR running CI - if it's the same we know it's something very else.

@EliahKagan
Copy link
Member

These lines from the GitHub Actions log reveal that this is due to a previously undetected bug in some code in GitPython's test suite. The bug is triggered by the (correct) changes topyproject.toml here.

I have implemented a fix in#1864, which also gives a more detailed analysis.

Borda reacted with thumbs up emoji

Copy link
Member

@EliahKaganEliahKagan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This looks good to me, and seems to cover all the bases.

(In particular, I agree with marking F401 unused-import as never automatically fixable. At leastfor now, some things would break if imports not listed in__all__ or directly used were removed.)

Together with#1864, the Cygwin test failure should go away. As mentioned there, I'm not sure of the best way to integrate them, but just about any way--including the simple way of just merging both, in either order--seems reasonable to me.

Borda reacted with thumbs up emojiByron and Borda reacted with rocket emoji
@Byron
Copy link
Member

Thanks@EliahKagan for the review and your help fixing the test failure.
@Borda I recommend rebasing this PR ontomain and it can be merged back.

Thanks everyone for the help and support!

EliahKagan and Borda reacted with thumbs up emoji

@Borda
Copy link
ContributorAuthor

Borda commentedMar 11, 2024
edited
Loading

I recommend rebasing this PR ontomain and it can be merged back.

@Byron done :)

Copy link
Member

@ByronByron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks a lot for contributing and for your incredibly swift responses!

Borda reacted with thumbs up emoji
@ByronByron merged commitedb8d26 intogitpython-developers:mainMar 11, 2024
@ByronByron changed the titlelint: replaceflake8 withruff check📣lint: replaceflake8 withruff check 📣Mar 11, 2024
@BordaBorda deleted the lint/ruff branchMarch 11, 2024 20:29
EliahKagan added a commit to EliahKagan/GitPython that referenced this pull requestMar 12, 2024
- `make lint` no longer lints without making changes.  This has been the case sincegitpython-developers#1862, because `--fix` is used.  (I don't think anyone was really using `make lint`, but just in  case, we should avoid saying it still never changes any files.)  Withgitpython-developers#1865, there will be more ways that files can be changed.- `black` is no longer used, having been replaced by `ruff`.  This will be the case as ofgitpython-developers#1865.This also reorganizes the "Specific tools" list, since they are allconfigured in pyproject.toml now (only flake8 was not before, andit was removed in favor of ruff ingitpython-developers#1862). In doing so, I've alsoadded brief parenthesized phrases to characterize what each ofthese four tools is for, so readers don't have to look around asmuch to understand most of the tooling GitPython has set up.
EliahKagan added a commit to EliahKagan/GitPython that referenced this pull requestMar 12, 2024
This is to make it so simple `tox` usage has the expected propertyof leaving all source code files in the working tree unchanged.As noted inc66257e, linting how sometimes performs auto-fixessincegitpython-developers#1862, and the pre-commit command in tox.ini, which had alsorun `black --check`, will do even more file editing withgitpython-developers#1865.The bifurcation for black into separate mutating and non-mutatinghooks, introduced in5d8ddd9 (gitpython-developers#1693), is not carried over into Ruffautoformatting ingitpython-developers#1865. But also it:- Was not necessarily a good approach, and likely should not be  preserved in any form. It is an unusual and unintuitive use of  pre-commit. (It can be brought back if no better approach is  found, though.)- Was done to avoid a situation where it was nontrivial to set up  necessary dependencies for linting in the GitPython virtual  environment itself, because flake8 and its various plugins would  have to be installed.  They were not listed in any existing or newly introduced extra  (for example, they were not added to test-requirements.txt) in  part in the hope that they would all be replaced by Ruff, which  happened ingitpython-developers#1862.- Already does not achieve its goal sincegitpython-developers#1862, since it was  (probably rightly) not extended to Ruff linting to use/omit --fix.Now that Ruff is being used, people can run `pip install ruff` in avirtual environment, then run the `ruff` command however they like.This takes the place of multiple tools and plugins.This commit *avoids* doing any of the following, even though it maybe useful to do them later:- This does not give specific instructions in the readme for  installing and running ruff (andc66257e before this also omits  that). This can be added later and the best way to document it  may depend on some other upcoming decisions (see below).- This does not add ruff to the test extra or as any other kind of  extra or optional dependency. Although the test extra currently  contains some packages not used for running unit tests, such as  pre-commit and mypy, adding Ruff will cause installation to take  a long time and/or or fail on some platforms like Cygwin where  Ruff has to be built from (Rust) source code. This can be solved  properly by reorganizing the extras, but that is likely to wait  until they are expressed completely inside pyproject.toml rather  than one per requirements file (see discussion in comments  ingitpython-developers#1716 for general information about possible forthcoming  changes in how the project is defined).- This does not update tox.ini to run ruff directly, which could be  done by splitting the current lint tox environment into two or  three environments for Python linting, Python autoformatting, and  the miscellaneous other tasks performed by pre-commit hooks, only  the latter of which would use the pre-commit command. Whether and  how this should be done may depend on other forthcoming changes.- This does not remove or update the Makefile "lint" target. That  target should perhaps not have been added, and was always meant  to be improved/replaced, since everything else in the top-level  Makefile is for building and publishing releases. See5d15063  (gitpython-developers#1693). This is likewise not done now since it may depend on  as-yet unmerged changes and tooling decisions not yet made. It  should be feasible to do together when further updating tox.ini.- This does not update tox.ini, Makefile, or the lint.yml GitHub  Actions workflow to omit the manual hook-stage, which will be  unused as ofgitpython-developers#1865. This would complicate integration of changes,  and once it is known that it won't be needed, it can removed.The situation with the tox "lint" environment is thus now similarto that of the tox "html" environment when it was added ine6ec6c8(gitpython-developers#1667), until it was improved inf094909 (gitpython-developers#1693) to run withproper isolation.
EliahKagan added a commit to EliahKagan/GitPython that referenced this pull requestMar 13, 2024
This also reorganizes the "Specific tools" list, since they are allconfigured in pyproject.toml now (only flake8 was not before, andit was removed in favor of ruff ingitpython-developers#1862). In doing so, I've alsoadded brief parenthesized phrases to characterize what each ofthese four tools is for, so readers don't have to look around asmuch to understand most of the tooling GitPython has set up.
EliahKagan added a commit to EliahKagan/GitPython that referenced this pull requestMar 13, 2024
This is to make it so simple `tox` usage has the expected propertyof leaving all source code files in the working tree unchanged.Linting how sometimes performs auto-fixes sincegitpython-developers#1862, and thepre-commit command in tox.ini, which had also run `black --check`,will do even more file editing due to the changes ingitpython-developers#1865.The bifurcation for black into separate mutating and non-mutatinghooks, introduced in5d8ddd9 (gitpython-developers#1693), was not carried over intoRuff autoformatting ingitpython-developers#1865. But also it:- Was not necessarily a good approach, and likely should not be  preserved in any form. It was an unusual and unintuitive use of  pre-commit. (It can be brought back if no better approach is  found, though.)- Was done to avoid a situation where it was nontrivial to set up  necessary dependencies for linting in the GitPython virtual  environment itself, because flake8 and its various plugins would  have to be installed.  They were not listed in any existing or newly introduced extra  (for example, they were not added to test-requirements.txt) in  part in the hope that they would all be replaced by Ruff, which  happened ingitpython-developers#1862.- Already did not achieve its goal as ofgitpython-developers#1862, since it was  (probably rightly) not extended to Ruff linting to use/omit --fix.Now that Ruff is being used, people can run `pip install ruff` in avirtual environment, then run the `ruff` command however they like.This takes the place of multiple tools and plugins.The situation with the tox "lint" environment is thus now similarto that of the tox "html" environment when it was added ine6ec6c8(gitpython-developers#1667), until it was improved inf094909 (gitpython-developers#1693) to run withproper isolation.
EliahKagan added a commit to EliahKagan/GitPython that referenced this pull requestMar 13, 2024
Although it seems likely that the requirements-dev.txt file will beremoved when the project definition is made declarative (discussedingitpython-developers#1716 comments), if not before, for now it exists and might bein use, so this updates it with tools that are currently used butnot listed in any extras or other requirements files:- ruff: This has replaced flake8 and its plugins (gitpython-developers#1862) as well as  black (gitpython-developers#1865). Currently there is no separate extra for tooling  that is not part of unit testing, with some such tools listed in  test-requirements.txt. The `ruff` package belongs here rather  than there for now because it should not be installed just to run  unit tests, since Ruff has to be built from source on some rarer  platforms like Cygwin, which would take a long time and/or fail.- shellcheck: The PyPI package for this is a convenience for  installing it in projects that are already using pip (shellcheck  is neither written in Python nor a tool to scan Python code). It  installs pre-built binaries, which are not available for all  platforms.These packages remain listed:- pytest-icdiff: This seems not to have been promoted to be in the  test-requirements.txt file and the `test` extra because it does  not work as well for diffs from tests that the pytest runner runs  but that are written for the unittest framework.- pytest-profiling [commented out]: I am not sure what the status  of this is, perhaps it has just not been experimented with  enough to know if it would be useful for profiling in GitPython.This requirements-dev.txt file has a few limitations that suggestit should be removed altogether sometime soon:- It is not updated regularly.- It is not always clear why something is there. Originally I  believe it was for tools where the desire to use the tool was  established but the tool did not yet work or worked but performed  checks for which code had to be fixed. That purpose has drifted.- It uses a different naming convention from the  test-requirements.txt file in active use.- It cannot be readily used to create an extra in the current  project definition in setup.py because the simple parsing done  there will not recognize the `-r` lines and will not skip the  comments, and neither enhancement should be done in setup.py  since that would move things farther away from a declarative  project definition.- It will naturally go away when the project definition is made  declarative, since it will then be feasible to define as many  extras as desired without proliferating separate requirements  files (while still allowing their contents to be statically  available to tools).Since it may go away soon and is not regularly updated, I have keptthe explanations for why particular packages are there out of it.But as long as it exists it may as well list the tools that reallyare being used yet are not explicitly listed as dependencies.
EliahKagan added a commit to EliahKagan/GitPython that referenced this pull requestMar 14, 2024
The conditional imports of Literal from either typing ortyping_extensions have to be done with if-else on the Pythonversion rather than with try-except, or it is a static type error.This makes that change, checking sys.version_info.(See discussion ingitpython-developers#1861 andgitpython-developers#1862 for broader context andbackground on why this logic, before and after this change, isrepeated across multiple modules.)This also reorders/regroups imports for consistency in some places,especially where a new import of the sys module (for version_info)would otherwise exacerbate inconsistency.Since the merge commit0b99041, the number of mypy errors hadincreased from 5 to 10. This fixes all the new mypy errors, so thecount is back to 5.
@ByronByron changed the title📣lint: replaceflake8 withruff check 📣lint: replaceflake8 withruff checkMar 15, 2024
renovatebot referenced this pull request in allenporter/flux-localMar 31, 2024
[![MendRenovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)This PR contains the following updates:| Package | Change | Age | Adoption | Passing | Confidence ||---|---|---|---|---|---|| [GitPython](https://togithub.com/gitpython-developers/GitPython) |`==3.1.42` -> `==3.1.43` |[![age](https://developer.mend.io/api/mc/badges/age/pypi/GitPython/3.1.43?slim=true)](https://docs.renovatebot.com/merge-confidence/)|[![adoption](https://developer.mend.io/api/mc/badges/adoption/pypi/GitPython/3.1.43?slim=true)](https://docs.renovatebot.com/merge-confidence/)|[![passing](https://developer.mend.io/api/mc/badges/compatibility/pypi/GitPython/3.1.42/3.1.43?slim=true)](https://docs.renovatebot.com/merge-confidence/)|[![confidence](https://developer.mend.io/api/mc/badges/confidence/pypi/GitPython/3.1.42/3.1.43?slim=true)](https://docs.renovatebot.com/merge-confidence/)|---### Release Notes<details><summary>gitpython-developers/GitPython (GitPython)</summary>###[`v3.1.43`](https://togithub.com/gitpython-developers/GitPython/releases/tag/3.1.43)[CompareSource](https://togithub.com/gitpython-developers/GitPython/compare/3.1.42...3.1.43)#### Particularly Important ChangesThese are likely to affect you, please do take a careful look.- Issue and test deprecation warnings by[@&#8203;EliahKagan](https://togithub.com/EliahKagan) in[https://github.com/gitpython-developers/GitPython/pull/1886](https://togithub.com/gitpython-developers/GitPython/pull/1886)- Fix version_info cache invalidation, typing, parsing, andserialization by [@&#8203;EliahKagan](https://togithub.com/EliahKagan)in[https://github.com/gitpython-developers/GitPython/pull/1838](https://togithub.com/gitpython-developers/GitPython/pull/1838)- Document manual refresh path treatment by[@&#8203;EliahKagan](https://togithub.com/EliahKagan) in[https://github.com/gitpython-developers/GitPython/pull/1839](https://togithub.com/gitpython-developers/GitPython/pull/1839)- Improve static typing and docstrings related to git object types by[@&#8203;EliahKagan](https://togithub.com/EliahKagan) in[https://github.com/gitpython-developers/GitPython/pull/1859](https://togithub.com/gitpython-developers/GitPython/pull/1859)#### Other Changes- Test in Docker with Alpine Linux on CI by[@&#8203;EliahKagan](https://togithub.com/EliahKagan) in[https://github.com/gitpython-developers/GitPython/pull/1826](https://togithub.com/gitpython-developers/GitPython/pull/1826)- Build online docs (RTD) with -W and dependencies by[@&#8203;EliahKagan](https://togithub.com/EliahKagan) in[https://github.com/gitpython-developers/GitPython/pull/1843](https://togithub.com/gitpython-developers/GitPython/pull/1843)- Suggest full-path refresh() in failure message by[@&#8203;EliahKagan](https://togithub.com/EliahKagan) in[https://github.com/gitpython-developers/GitPython/pull/1844](https://togithub.com/gitpython-developers/GitPython/pull/1844)- `repo.blame` and `repo.blame_incremental` now accept `None` as the`rev` parameter. by [@&#8203;Gaubbe](https://togithub.com/Gaubbe) in[https://github.com/gitpython-developers/GitPython/pull/1846](https://togithub.com/gitpython-developers/GitPython/pull/1846)- Make sure diff always uses the default diff driver when`create_patch=True` by[@&#8203;can-taslicukur](https://togithub.com/can-taslicukur) in[https://github.com/gitpython-developers/GitPython/pull/1832](https://togithub.com/gitpython-developers/GitPython/pull/1832)- Revise docstrings, comments, and a few messages by[@&#8203;EliahKagan](https://togithub.com/EliahKagan) in[https://github.com/gitpython-developers/GitPython/pull/1850](https://togithub.com/gitpython-developers/GitPython/pull/1850)- Expand what is included in the API Reference by[@&#8203;EliahKagan](https://togithub.com/EliahKagan) in[https://github.com/gitpython-developers/GitPython/pull/1855](https://togithub.com/gitpython-developers/GitPython/pull/1855)- Restore building of documentation downloads by[@&#8203;EliahKagan](https://togithub.com/EliahKagan) in[https://github.com/gitpython-developers/GitPython/pull/1856](https://togithub.com/gitpython-developers/GitPython/pull/1856)- Revise type annotations slightly by[@&#8203;EliahKagan](https://togithub.com/EliahKagan) in[https://github.com/gitpython-developers/GitPython/pull/1860](https://togithub.com/gitpython-developers/GitPython/pull/1860)- Updating regex pattern to handle unicode whitespaces. by[@&#8203;jcole-crowdstrike](https://togithub.com/jcole-crowdstrike) in[https://github.com/gitpython-developers/GitPython/pull/1853](https://togithub.com/gitpython-developers/GitPython/pull/1853)- Use upgraded pip in test fixture virtual environment by[@&#8203;EliahKagan](https://togithub.com/EliahKagan) in[https://github.com/gitpython-developers/GitPython/pull/1864](https://togithub.com/gitpython-developers/GitPython/pull/1864)- lint: replace `flake8` with `ruff` check by[@&#8203;Borda](https://togithub.com/Borda) in[https://github.com/gitpython-developers/GitPython/pull/1862](https://togithub.com/gitpython-developers/GitPython/pull/1862)- lint: switch Black with `ruff-format` by[@&#8203;Borda](https://togithub.com/Borda) in[https://github.com/gitpython-developers/GitPython/pull/1865](https://togithub.com/gitpython-developers/GitPython/pull/1865)- Update readme and tox.ini for recent tooling changes by[@&#8203;EliahKagan](https://togithub.com/EliahKagan) in[https://github.com/gitpython-developers/GitPython/pull/1868](https://togithub.com/gitpython-developers/GitPython/pull/1868)- Split tox lint env into three envs, all safe by[@&#8203;EliahKagan](https://togithub.com/EliahKagan) in[https://github.com/gitpython-developers/GitPython/pull/1870](https://togithub.com/gitpython-developers/GitPython/pull/1870)- Slightly broaden Ruff, and update and clarify tool configuration by[@&#8203;EliahKagan](https://togithub.com/EliahKagan) in[https://github.com/gitpython-developers/GitPython/pull/1871](https://togithub.com/gitpython-developers/GitPython/pull/1871)- Add a "doc" extra for documentation build dependencies by[@&#8203;EliahKagan](https://togithub.com/EliahKagan) in[https://github.com/gitpython-developers/GitPython/pull/1872](https://togithub.com/gitpython-developers/GitPython/pull/1872)- Describe `Submodule.__init__` parent_commit parameter by[@&#8203;EliahKagan](https://togithub.com/EliahKagan) in[https://github.com/gitpython-developers/GitPython/pull/1877](https://togithub.com/gitpython-developers/GitPython/pull/1877)- Include TagObject in git.types.Tree_ish by[@&#8203;EliahKagan](https://togithub.com/EliahKagan) in[https://github.com/gitpython-developers/GitPython/pull/1878](https://togithub.com/gitpython-developers/GitPython/pull/1878)- Improve Sphinx role usage, including linking Git manpages by[@&#8203;EliahKagan](https://togithub.com/EliahKagan) in[https://github.com/gitpython-developers/GitPython/pull/1879](https://togithub.com/gitpython-developers/GitPython/pull/1879)- Replace all wildcard imports with explicit imports by[@&#8203;EliahKagan](https://togithub.com/EliahKagan) in[https://github.com/gitpython-developers/GitPython/pull/1880](https://togithub.com/gitpython-developers/GitPython/pull/1880)- Clarify how tag objects are usually tree-ish and commit-ish by[@&#8203;EliahKagan](https://togithub.com/EliahKagan) in[https://github.com/gitpython-developers/GitPython/pull/1881](https://togithub.com/gitpython-developers/GitPython/pull/1881)#### New Contributors- [@&#8203;Gaubbe](https://togithub.com/Gaubbe) made their firstcontribution in[https://github.com/gitpython-developers/GitPython/pull/1846](https://togithub.com/gitpython-developers/GitPython/pull/1846)- [@&#8203;can-taslicukur](https://togithub.com/can-taslicukur) madetheir first contribution in[https://github.com/gitpython-developers/GitPython/pull/1832](https://togithub.com/gitpython-developers/GitPython/pull/1832)- [@&#8203;jcole-crowdstrike](https://togithub.com/jcole-crowdstrike)made their first contribution in[https://github.com/gitpython-developers/GitPython/pull/1853](https://togithub.com/gitpython-developers/GitPython/pull/1853)- [@&#8203;Borda](https://togithub.com/Borda) made their firstcontribution in[https://github.com/gitpython-developers/GitPython/pull/1862](https://togithub.com/gitpython-developers/GitPython/pull/1862)**Full Changelog**:gitpython-developers/GitPython@3.1.42...3.1.43</details>---### Configuration📅 **Schedule**: Branch creation - At any time (no schedule defined),Automerge - At any time (no schedule defined).🚦 **Automerge**: Enabled.♻ **Rebasing**: Whenever PR becomes conflicted, or you tick therebase/retry checkbox.🔕 **Ignore**: Close this PR and you won't be reminded about this updateagain.---- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, checkthis box---This PR has been generated by [MendRenovate](https://www.mend.io/free-developer-tools/renovate/). Viewrepository job log[here](https://developer.mend.io/github/allenporter/flux-local).<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yNjkuMiIsInVwZGF0ZWRJblZlciI6IjM3LjI2OS4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
lettuce-botbot referenced this pull request in lettuce-financial/github-bot-signed-commitApr 1, 2024
[![MendRenovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)This PR contains the following updates:| Package | Change | Age | Adoption | Passing | Confidence ||---|---|---|---|---|---|| [GitPython](https://togithub.com/gitpython-developers/GitPython) |`==3.1.42` -> `==3.1.43` |[![age](https://developer.mend.io/api/mc/badges/age/pypi/GitPython/3.1.43?slim=true)](https://docs.renovatebot.com/merge-confidence/)|[![adoption](https://developer.mend.io/api/mc/badges/adoption/pypi/GitPython/3.1.43?slim=true)](https://docs.renovatebot.com/merge-confidence/)|[![passing](https://developer.mend.io/api/mc/badges/compatibility/pypi/GitPython/3.1.42/3.1.43?slim=true)](https://docs.renovatebot.com/merge-confidence/)|[![confidence](https://developer.mend.io/api/mc/badges/confidence/pypi/GitPython/3.1.42/3.1.43?slim=true)](https://docs.renovatebot.com/merge-confidence/)|---### Release Notes<details><summary>gitpython-developers/GitPython (GitPython)</summary>###[`v3.1.43`](https://togithub.com/gitpython-developers/GitPython/releases/tag/3.1.43)[CompareSource](https://togithub.com/gitpython-developers/GitPython/compare/3.1.42...3.1.43)#### Particularly Important ChangesThese are likely to affect you, please do take a careful look.- Issue and test deprecation warnings by[@&#8203;EliahKagan](https://togithub.com/EliahKagan) in[https://github.com/gitpython-developers/GitPython/pull/1886](https://togithub.com/gitpython-developers/GitPython/pull/1886)- Fix version_info cache invalidation, typing, parsing, andserialization by [@&#8203;EliahKagan](https://togithub.com/EliahKagan)in[https://github.com/gitpython-developers/GitPython/pull/1838](https://togithub.com/gitpython-developers/GitPython/pull/1838)- Document manual refresh path treatment by[@&#8203;EliahKagan](https://togithub.com/EliahKagan) in[https://github.com/gitpython-developers/GitPython/pull/1839](https://togithub.com/gitpython-developers/GitPython/pull/1839)- Improve static typing and docstrings related to git object types by[@&#8203;EliahKagan](https://togithub.com/EliahKagan) in[https://github.com/gitpython-developers/GitPython/pull/1859](https://togithub.com/gitpython-developers/GitPython/pull/1859)#### Other Changes- Test in Docker with Alpine Linux on CI by[@&#8203;EliahKagan](https://togithub.com/EliahKagan) in[https://github.com/gitpython-developers/GitPython/pull/1826](https://togithub.com/gitpython-developers/GitPython/pull/1826)- Build online docs (RTD) with -W and dependencies by[@&#8203;EliahKagan](https://togithub.com/EliahKagan) in[https://github.com/gitpython-developers/GitPython/pull/1843](https://togithub.com/gitpython-developers/GitPython/pull/1843)- Suggest full-path refresh() in failure message by[@&#8203;EliahKagan](https://togithub.com/EliahKagan) in[https://github.com/gitpython-developers/GitPython/pull/1844](https://togithub.com/gitpython-developers/GitPython/pull/1844)- `repo.blame` and `repo.blame_incremental` now accept `None` as the`rev` parameter. by [@&#8203;Gaubbe](https://togithub.com/Gaubbe) in[https://github.com/gitpython-developers/GitPython/pull/1846](https://togithub.com/gitpython-developers/GitPython/pull/1846)- Make sure diff always uses the default diff driver when`create_patch=True` by[@&#8203;can-taslicukur](https://togithub.com/can-taslicukur) in[https://github.com/gitpython-developers/GitPython/pull/1832](https://togithub.com/gitpython-developers/GitPython/pull/1832)- Revise docstrings, comments, and a few messages by[@&#8203;EliahKagan](https://togithub.com/EliahKagan) in[https://github.com/gitpython-developers/GitPython/pull/1850](https://togithub.com/gitpython-developers/GitPython/pull/1850)- Expand what is included in the API Reference by[@&#8203;EliahKagan](https://togithub.com/EliahKagan) in[https://github.com/gitpython-developers/GitPython/pull/1855](https://togithub.com/gitpython-developers/GitPython/pull/1855)- Restore building of documentation downloads by[@&#8203;EliahKagan](https://togithub.com/EliahKagan) in[https://github.com/gitpython-developers/GitPython/pull/1856](https://togithub.com/gitpython-developers/GitPython/pull/1856)- Revise type annotations slightly by[@&#8203;EliahKagan](https://togithub.com/EliahKagan) in[https://github.com/gitpython-developers/GitPython/pull/1860](https://togithub.com/gitpython-developers/GitPython/pull/1860)- Updating regex pattern to handle unicode whitespaces. by[@&#8203;jcole-crowdstrike](https://togithub.com/jcole-crowdstrike) in[https://github.com/gitpython-developers/GitPython/pull/1853](https://togithub.com/gitpython-developers/GitPython/pull/1853)- Use upgraded pip in test fixture virtual environment by[@&#8203;EliahKagan](https://togithub.com/EliahKagan) in[https://github.com/gitpython-developers/GitPython/pull/1864](https://togithub.com/gitpython-developers/GitPython/pull/1864)- lint: replace `flake8` with `ruff` check by[@&#8203;Borda](https://togithub.com/Borda) in[https://github.com/gitpython-developers/GitPython/pull/1862](https://togithub.com/gitpython-developers/GitPython/pull/1862)- lint: switch Black with `ruff-format` by[@&#8203;Borda](https://togithub.com/Borda) in[https://github.com/gitpython-developers/GitPython/pull/1865](https://togithub.com/gitpython-developers/GitPython/pull/1865)- Update readme and tox.ini for recent tooling changes by[@&#8203;EliahKagan](https://togithub.com/EliahKagan) in[https://github.com/gitpython-developers/GitPython/pull/1868](https://togithub.com/gitpython-developers/GitPython/pull/1868)- Split tox lint env into three envs, all safe by[@&#8203;EliahKagan](https://togithub.com/EliahKagan) in[https://github.com/gitpython-developers/GitPython/pull/1870](https://togithub.com/gitpython-developers/GitPython/pull/1870)- Slightly broaden Ruff, and update and clarify tool configuration by[@&#8203;EliahKagan](https://togithub.com/EliahKagan) in[https://github.com/gitpython-developers/GitPython/pull/1871](https://togithub.com/gitpython-developers/GitPython/pull/1871)- Add a "doc" extra for documentation build dependencies by[@&#8203;EliahKagan](https://togithub.com/EliahKagan) in[https://github.com/gitpython-developers/GitPython/pull/1872](https://togithub.com/gitpython-developers/GitPython/pull/1872)- Describe `Submodule.__init__` parent_commit parameter by[@&#8203;EliahKagan](https://togithub.com/EliahKagan) in[https://github.com/gitpython-developers/GitPython/pull/1877](https://togithub.com/gitpython-developers/GitPython/pull/1877)- Include TagObject in git.types.Tree_ish by[@&#8203;EliahKagan](https://togithub.com/EliahKagan) in[https://github.com/gitpython-developers/GitPython/pull/1878](https://togithub.com/gitpython-developers/GitPython/pull/1878)- Improve Sphinx role usage, including linking Git manpages by[@&#8203;EliahKagan](https://togithub.com/EliahKagan) in[https://github.com/gitpython-developers/GitPython/pull/1879](https://togithub.com/gitpython-developers/GitPython/pull/1879)- Replace all wildcard imports with explicit imports by[@&#8203;EliahKagan](https://togithub.com/EliahKagan) in[https://github.com/gitpython-developers/GitPython/pull/1880](https://togithub.com/gitpython-developers/GitPython/pull/1880)- Clarify how tag objects are usually tree-ish and commit-ish by[@&#8203;EliahKagan](https://togithub.com/EliahKagan) in[https://github.com/gitpython-developers/GitPython/pull/1881](https://togithub.com/gitpython-developers/GitPython/pull/1881)#### New Contributors- [@&#8203;Gaubbe](https://togithub.com/Gaubbe) made their firstcontribution in[https://github.com/gitpython-developers/GitPython/pull/1846](https://togithub.com/gitpython-developers/GitPython/pull/1846)- [@&#8203;can-taslicukur](https://togithub.com/can-taslicukur) madetheir first contribution in[https://github.com/gitpython-developers/GitPython/pull/1832](https://togithub.com/gitpython-developers/GitPython/pull/1832)- [@&#8203;jcole-crowdstrike](https://togithub.com/jcole-crowdstrike)made their first contribution in[https://github.com/gitpython-developers/GitPython/pull/1853](https://togithub.com/gitpython-developers/GitPython/pull/1853)- [@&#8203;Borda](https://togithub.com/Borda) made their firstcontribution in[https://github.com/gitpython-developers/GitPython/pull/1862](https://togithub.com/gitpython-developers/GitPython/pull/1862)**Full Changelog**:gitpython-developers/GitPython@3.1.42...3.1.43</details>---### Configuration📅 **Schedule**: Branch creation - At any time (no schedule defined),Automerge - At any time (no schedule defined).🚦 **Automerge**: Disabled by config. Please merge this manually once youare satisfied.♻ **Rebasing**: Whenever PR becomes conflicted, or you tick therebase/retry checkbox.🔕 **Ignore**: Close this PR and you won't be reminded about theseupdates again.---- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, checkthis box---This PR has been generated by [MendRenovate](https://www.mend.io/free-developer-tools/renovate/). Viewrepository job log[here](https://developer.mend.io/github/lettuce-financial/github-bot-signed-commit).<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yNjkuMiIsInVwZGF0ZWRJblZlciI6IjM3LjI2OS4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@ByronByronByron approved these changes

@EliahKaganEliahKaganEliahKagan approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

switch to Ruff instead offlake8
3 participants
@Borda@Byron@EliahKagan

[8]ページ先頭

©2009-2025 Movatter.jp