Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork938
Fix version_info cache invalidation, typing, parsing, and serialization#1838
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Merged
Changes fromall commits
Commits
Show all changes
19 commits Select commitHold shift + click to select a range
e40fc2c
Use TemporaryFile as a context manager
EliahKagan1de2fdc
Test that version_info caches
EliahKagan3f107d5
Test that version_info caching is per instance
EliahKagan2eac36c
Have _fake_git fixture take version_info
EliahKagan2d6311b
Test version_info on unpickled Git instance
EliahKaganf699a38
Fix Git.version_info pickling
EliahKagan634b618
Use documented version_info in test_index_file_diffing
EliahKagan626a550
Test that refreshing invalidates cached version_info
EliahKagan9151c38
Test "installing" another git and refreshing
EliahKaganc2d72ff
Simplify patched PATH env var construction
EliahKaganee385bd
Make "install" and refresh version_info test portable
EliahKagan2940662
Test that version_info is not pickled
EliahKagane3e5687
Fix tests for Python <3.9 which lack Path.with_stem
EliahKagan24b065e
Invalidate all cached version_info on refresh
EliahKagan82b0a1e
Clarify comments; add assertion (helps mypy)
EliahKaganeb438ee
Refactor and further clarify comments
EliahKagandc6b90f
Fix version_info type hint + more refactoring
EliahKaganac20325
Test version_info parsing
EliahKagan629fd87
Fix how version_info omits non-numeric fields
EliahKaganFile filter
Filter by extension
Conversations
Failed to load comments.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Jump to
Jump to file
Failed to load files.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Diff view
Diff view
There are no files selected for viewing
62 changes: 40 additions & 22 deletionsgit/cmd.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Oops, something went wrong.
Uh oh!
There was an error while loading.Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.