Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Closing file handles/streams#176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

craigez
Copy link
Contributor

Our debugging of GitPython during usage a while ago showed we were leaking some file handles. We think this resolves some of the issues.

@Byron
Copy link
Member

Thanks a lot for this contribution - plenty of issues showed up in the past because of this !

Byron added a commit that referenced this pull requestJul 25, 2014
@ByronByron merged commit22a2103 intogitpython-developers:masterJul 25, 2014
@craigez
Copy link
ContributorAuthor

There are sill more somewhere but we haven't found them yet.

@Byron
Copy link
Member

Gitdb is the other location which deals with files, sometimes indirectly through the use of smmap. I would suspect smmap, as each mmap opened on a file will effectively duplicate the file-handle. If the original is not closed, there would be a leak. It's just a guess of mine, which would need to be verified.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@craigez@Byron

[8]ページ先頭

©2009-2025 Movatter.jp