Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork939
Closing file handles/streams#176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Thanks a lot for this contribution - plenty of issues showed up in the past because of this ! |
There are sill more somewhere but we haven't found them yet. |
Gitdb is the other location which deals with files, sometimes indirectly through the use of smmap. I would suspect smmap, as each mmap opened on a file will effectively duplicate the file-handle. If the original is not closed, there would be a leak. It's just a guess of mine, which would need to be verified. |
Our debugging of GitPython during usage a while ago showed we were leaking some file handles. We think this resolves some of the issues.