Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork940
Proposition to make comparisons between GitPython objects and non-GitPython objects possible.#16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Hi Mike, I specifically favored performance when implementing this, hence there are no extra compatibility checks, but the question is where this tad of performance will make an actual difference. People who want performance would save the method call and just do the A little bit of convenience is probably not a bad idea in this case, and I merged your request. Thanks, |
improved comparison between Object instances to check for compatibility of the other side first. Previously, and exception would be thrown.This adds convenience in an area which probably is not performance critical.
In order to be able to compare for instance None with a Commit, I'm suggesting that we check that 'other' has the attribute binsha before comparing. (also, see issue#15).
Thanks.