Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Proposition to make comparisons between GitPython objects and non-GitPython objects possible.#16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
Byron merged 1 commit intogitpython-developers:masterfrommike-perdide:master
May 19, 2011

Conversation

mike-perdide
Copy link

In order to be able to compare for instance None with a Commit, I'm suggesting that we check that 'other' has the attribute binsha before comparing. (also, see issue#15).

Thanks.

@Byron
Copy link
Member

Hi Mike,

I specifically favored performance when implementing this, hence there are no extra compatibility checks, but the question is where this tad of performance will make an actual difference. People who want performance would save the method call and just do thelhs.binsha == rhs.binsha themselves.

A little bit of convenience is probably not a bad idea in this case, and I merged your request.

Thanks,
Sebastian

Byron added a commit that referenced this pull requestMay 19, 2011
improved comparison between Object instances to check for compatibility of the other side first. Previously, and exception would be thrown.This adds convenience in an area which probably is not performance critical.
@ByronByron merged commit35bceb1 intogitpython-developers:masterMay 19, 2011
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@mike-perdide@Byron

[8]ページ先頭

©2009-2025 Movatter.jp