Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork939
Fix RecursionError when iterating streams#1554
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Thanks a lot, I have a feeling that this issue was present for a long time already! Do you think Python 2 compatibility is still required? Support for it was dropped a while ago and if you agree it can be dropped entirely. |
I have no objection to dropping the |
| next = __next__ | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Feel free to commit through the github UI if you want to drop this Python2 compatibility layer entirely:
| next = __next__ |
Note that there may be some downstream code that relies on usingnext because__next__ was broken though!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Ah, right. Oh well, let's be conservative then.
Great! Let's do that and the PR can be merged. Thank you |
next(self)was previously just a recursive call that does nothing.This now implements
__next__using the actual implementation, and lets the python2-compatibilitynext()just wrap it.