Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Fix timezone parsing functions for non-hour timezones#1547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

jcowgill
Copy link
Contributor

Theutctz_to_altz andaltz_to_utctz_str functions fail to handle timezones with UTC offsets that are not a multiple of one hour. Rewrite them and add some unit tests.

Fixes#630

The `utctz_to_altz` and `altz_to_utctz_str` functions fail to handletimezones with UTC offsets that are not a multiple of onehour. Rewrite them and add some unit tests.Fixesgitpython-developers#630
Copy link
Member

@ByronByron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks a million, this is long overdue!

@ByronByron added this to thev3.1.31 - Bugfixes milestoneJan 25, 2023
@Byron
Copy link
Member

By the way, I can imagine a round-trip test that runs from-12*3600 to12 * 3600 and assures thatb(a(t)) == t for each second this loop produces. If you are intrigued, maybe submit another PR for that :).

@ByronByron merged commit63a60b3 intogitpython-developers:mainJan 25, 2023
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@ByronByronByron approved these changes

Assignees
No one assigned
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Wrong timezone on commit
2 participants
@jcowgill@Byron
[8]ページ先頭
©2009-2025 Movatter.jp