Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Fix ignored#1545

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
Byron merged 3 commits intogitpython-developers:mainfromLightborne:fix_ignored
Jan 22, 2023
Merged

Fix ignored#1545

Byron merged 3 commits intogitpython-developers:mainfromLightborne:fix_ignored
Jan 22, 2023

Conversation

Lightborne
Copy link
Contributor

  • Add test to sanity-check basic behavior ofignored() method
  • Add test to verify GitCommandError is raised ifgit check-ignore returns any error code other than 1
  • Modifyignred() method to raise GitCommandError ifgit check-ignore returns any error code other than 1

@Byron
Copy link
Member

Great work, thanks so much! I love to finally have a test for that.

For a moment I thought this might be a breaking change, just to realize that the previous implementation was just a little too 'unconditional' and this PR implements the proper fix by raising an error when the error code doesnot indicate a lack of matches.

@ByronByron merged commitcc92d51 intogitpython-developers:mainJan 22, 2023
@Lightborne
Copy link
ContributorAuthor

Thanks so much!

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
@Lightborne@Byron
[8]ページ先頭
©2009-2025 Movatter.jp