Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Fix some resource leaks by open file handles#1532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

marlamb
Copy link

No description provided.

@marlambmarlambforce-pushed thefeature/reduce-resource-leaks branch from752dd1a tod3dbe6cCompareJanuary 8, 2023 23:05
@marlambmarlambforce-pushed thefeature/reduce-resource-leaks branch fromd3dbe6c toe500466CompareJanuary 8, 2023 23:10
@ByronByron added this to thev3.1.31 - Bugfixes milestoneJan 9, 2023
@Byron
Copy link
Member

Thanks a lot, amazing fixes!
It's odd that these survived so long, maybe this indicates the GitPython is mostly used in one-off commands rather than long running processes.

@ByronByron merged commit90c81a5 intogitpython-developers:mainJan 9, 2023
@marlamb
Copy link
Author

You are welcome, thanks for merging that quickly!

@Codym48
Copy link
Contributor

Thank you for committing this@marlamb and merging it@Byron!

(We only tripped over one of these after we enabledfilterwarnings("error") and executed the pytest suite locally within alinked worktree. It didn't appear when running within the main worktree or within any CI pipeline.)

Any idea when the next release is scheduled? Can I volunteer to help?

@Byron
Copy link
Member

@Codym48 Thanks for your help! It would be great if#1535 cold be merged before a release is created, it's just missing a test. You could probably submit a PR on top of that one to add it. Thank you.

@Codym48
Copy link
Contributor

How about something like this?kfreezen#1

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
@marlamb@Byron@Codym48
[8]ページ先頭
©2009-2025 Movatter.jp