Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Ignore empty info in diff line#1497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
Byron merged 1 commit intogitpython-developers:mainfromdwapstra:git_diff_empty
Sep 27, 2022

Conversation

dwapstra
Copy link
Contributor

In some cases, the git diff command does not return any output, this results in an exception in the diff line handling code.

  File "../lib/python3.8/site-packages/git/diff.py", line 502, in _handle_diff_line    old_mode, new_mode, a_blob_id, b_blob_id, _change_type = meta.split(None, 4)ValueError: not enough values to unpack (expected 5, got 1)

This fix ignores empty diff lines.

@ByronByron added this to thev3.1.28 - Bugfixes milestoneSep 27, 2022
@Byron
Copy link
Member

Thanks a lot. This is probably an example for 'the perfect PR': Bite-sized, with concise description, and CI is happy, too :).

@ByronByron merged commit0d28eaa intogitpython-developers:mainSep 27, 2022
@dwapstradwapstra deleted the git_diff_empty branchSeptember 28, 2022 18:42
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
@dwapstra@Byron
[8]ページ先頭
©2009-2025 Movatter.jp