Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork966
Suggested fixes by iCR, OpenRefactory, Inc.#1486
Closed
openrefactory wants to merge 1 commit intogitpython-developers:mainfrom
Closed
Suggested fixes by iCR, OpenRefactory, Inc.#1486openrefactory wants to merge 1 commit intogitpython-developers:mainfrom
openrefactory wants to merge 1 commit intogitpython-developers:mainfrom
Conversation
Member
Byron commentedAug 31, 2022
It's by design, the temporary file has to be opened and written by |
Member
EliahKagan commentedDec 22, 2023 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This issue was detected in branch
mainofGitPythonproject on the version with commit hash73bde1. This is an instance of an improper method callFixes for improper method call:
In file:
base.py, there is a methodfrom_treethat creates a temporary file using an unsafe APImktemp. The use of this method is discouraged in thePython documentation.iCR suggested that a temporary file should be created usingNamedTemporaryFilewhich is aa safe API.iCR replaced the usage ofmktempwithNamedTemporaryFile.In file:
util.py, there is a method__init__that creates a temporary file using an unsafe APImktemp. The use of this method is discouraged in thePython documentation.iCR suggested that a temporary file should be created usingNamedTemporaryFilewhich is aa safe API.iCR replaced the usage ofmktempwithNamedTemporaryFile.This issue was detected byOpenRefactory's Intelligent Code Repair (iCR). We are runningiCR on libraries in the
PyPIrepository to identify issues and fix them. More info at:pypi.openrefactory.com