Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Fix incomplete typehinting for PathLike#1474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
Byron merged 4 commits intogitpython-developers:mainfrommadebylydia:master
Aug 8, 2022
Merged

Fix incomplete typehinting for PathLike#1474

Byron merged 4 commits intogitpython-developers:mainfrommadebylydia:master
Aug 8, 2022

Conversation

madebylydia
Copy link
Contributor

This adds a more rich type hinting for thegit.types.PathLike class.
Closes#1473.

Also remove unused imports in this file.

@madebylydia
Copy link
ContributorAuthor

I'm unsure that the check has failed due to the change because I am unable to run flake8 myself for some reasons... Even after rolling back my changes
image
I'm confused, and might require a hand on how to fix the following...

@ByronByron requested a review fromYobmodAugust 1, 2022 00:47
@Byron
Copy link
Member

Byron commentedAug 1, 2022•
edited
Loading

Thanks for addingbytes, in theory itshould now be ready. I myself am not sure what's going on with flake8 except that it's probably buggy in the latest version.

Maybe this PR can be re-run occasionally to see if that fixes it as it should pull the latest version and fixed version of flake at some point.

I also asked@Yobmod for assistance, maybe they have seen this issue before.

@madebylydia
Copy link
ContributorAuthor

madebylydia commentedAug 1, 2022 via email

Hello, please do not merge this PR as it appears the current fix might notbe correct.As per the current fix, Pylance/mypy will complain that a str object doesnot comply with the type hint. I assume it would be the same error raisedif I pass a byte object, but complaining it's not a str this time, I assume.I need to investigate and see what else I can do, but this might be tricky.
…
On Mon, Aug 1, 2022, 02:51 Sebastian Thiel ***@***.***> wrote: Thanks for adding bytes, in theory it *should* now be ready. I myself am not sure what's going on with flake8 except that it's probably buggy in the latest version. Maybe this PR can be re-run occasionally to see if that fixes it as it should pull the latest version and fixed version of flake at some point. — Reply to this email directly, view it on GitHub <#1474 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AOSDPZ3QOGJQ3SPPBXZ7INDVW4NSDANCNFSM55FN4VFQ> . You are receiving this because you authored the thread.Message ID: ***@***.***>

Predeactor added2 commitsAugust 7, 2022 18:31
Signed-off-by: Predeactor <predeactor0@gmail.com>
Signed-off-by: Predeactor <predeactor0@gmail.com>
@ByronByron merged commit1c0f307 intogitpython-developers:mainAug 8, 2022
@ByronByron added this to thev3.1.28 - Bugfixes milestoneAug 8, 2022
@Byron
Copy link
Member

Thanks a lot for figuring this out with me!

@madebylydia
Copy link
ContributorAuthor

You're welcome!

@madebylydiamadebylydia deleted the master branchAugust 8, 2022 11:23
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@YobmodYobmodAwaiting requested review from Yobmod

Assignees
No one assigned
Labels
None yet
Development

Successfully merging this pull request may close these issues.

git.types.PathLike is partially unknown for Pylance/mypy
2 participants
@madebylydia@Byron
[8]ページ先頭
©2009-2025 Movatter.jp