Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork941
Run everything through 'black'#1442
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
2574989
tof501fcb
CompareEliahKagan added a commit to EliahKagan/GitPython that referenced this pull requestMar 10, 2024
The superclass _traverse method call in Tree.traverse appears tohave once had a working suppression for the incompatbile types oftwo arguments, `predicate` and `prune`, as well as for an argumentthat required (and requires) no suppression, `depth`. These threearguments were written on the same line, which bad a `type: ignore`comment on it. But when black formatting was applied in21ec529(gitpython-developers#1442), that comment moved so that it was on a line with just the`depth` call that didn't need it, rather than the others that did.Since then, mypy has reported errors, which further seem intendedto suppress based on the surrounding context and the use of `cast`to deal with the static type incompatibilities going the other way.This misplaced suppression was one of the ones I very recentlyremoved in84fc806. But really there should be a suppression forthose arguments (at least for now, while the code remains writtenthat way, given that a suppression is intended).This suppresses the error effectively by inserting two suppressioncomments, one for each of the two arguments. This is more specificthan a single suppression applying to the whole call, and keepingthe arguments on separate lines both makes black happy and makesclear that it is not by coincidence that the error is suppressedfor both of them. The new suppressions are also written for thespecific mypy error at issue, rather than fully general as before.This change decreases the number of mypy errors by two.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
That way people who use it won't be deterred, while it unifies style
everywhere.