Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix: Allow adding PathLike object to index#1440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
Byron merged 1 commit intogitpython-developers:mainfromrdbisme:index-pathlike
May 18, 2022

Conversation

rdbisme
Copy link

@rdbismerdbisme commentedMay 17, 2022
edited
Loading

Close#1382

Apart from the automatic linting, relevant lines arehere + the additional test

Copy link
Member

@ByronByron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

May I ask to adjust the commits to not do code formatting? I am happy to run it through black to unify the style and if it doesn't make it (too much) worse, but that should be a separate step.

All these changes are like noise to the signal making a review harder than it has to be. Thanks.

@Byron
Copy link
Member

Byron commentedMay 18, 2022
edited
Loading

Great, thanks a lot, particularly for the test.

@ByronByron merged commitd96f671 intogitpython-developers:mainMay 18, 2022
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@ByronByronByron requested changes

Assignees
No one assigned
Labels
None yet
Development

Successfully merging this pull request may close these issues.

repo.index.add() first argument type accepts os.PathLike but code raises TypeError
2 participants
@rdbisme@Byron

[8]ページ先頭

©2009-2025 Movatter.jp