Close .git/index file descriptor#1394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Closed

skshetry wants to merge1 commit intogitpython-developers:mainfromskshetry:close-fd

Closed

Close .git/index file descriptor#1394

skshetry wants to merge1 commit intogitpython-developers:mainfromskshetry:close-fd

Conversation

Copy link

Contributor

skshetry commentedJan 10, 2022

The index fd is not closed, which makes it fail on Windows with PermissionError:

E PermissionError: [WinError 32] The process cannot access the file because it is being used by another process: 'C:\\Users\\runneradmin\\AppData\\Local\\Temp\\pytest-of-runneradmin\\pytest-0\\test_commit_in_root_repo_with_0\\.git\\index'

and sometimes with not much information when using APIs that interact with git binary:

fatal: Unable to write new index file

Also seeiterative/scmrepo#27 andconda-forge/gitpython-feedstock#62.

This regression was introduced on#1391 (specifically ond79d20d, and released on 3.1.25).

Close .git/index file descriptor

6a47114

skshetry force-pushed theclose-fd branch frombf1f775 to6a47114Compare

January 10, 2022 10:44

IRDonch mentioned this pull request

Jan 10, 2022

Remove hacks that were added to work around issues in pycocotoolsopen-edge-platform/datumaro#449

Merged

7 tasks

Byron added the acknowledged label

Jan 10, 2022

Byron added a commit that referenced this pull request

Jan 10, 2022

Assure index file descriptor is closed after reader (#1394) (#1395)

e16a004

A regression that was introduced withd79d20d.

Copy link

Member

Byron commentedJan 10, 2022

Thanks a lot for the fix. I thought that usingtry:finally might be even safer and implemented that ine16a004, which is why this PR has to be closed without merging.

A new release will be created within a couple of minutes.