Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork941
Revert use of Typeguard and therefore typing-extensions==3.10.0.0#1298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Thank you! I will create a new release on your mark. |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Downgrade typing-extensions back to 3.7.4.3 and remove Typeguard.
Typing-extensions 3.10.0.0 keeps giving problems even after the requirements.txt updated. Its been out for 3 months, but installing from Testpypi says it doesnt exist (have to install it manually first), and lots of libraries are still fixed to 3.7.4.x (including tensorflow and VScode's restructured text linter?!)
I've commented out all the function defs that use Typeguard, so they can be put back once the world updates. In the meantime, i replaced them all with 'cast' to keep mypy happy.
Added more complex typing to BaseIndexEntry, SectionConstraint, GitConfigParser, _OMD.
Rmved with_metaclass shim, not needed for python 3.
Already includes the changes from previous PR that fixed the py.typed issue in setup.py.
#1095