Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Add types to refs#1295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
Byron merged 22 commits intogitpython-developers:mainfromYobmod:main
Jul 19, 2021
Merged

Add types to refs#1295

Byron merged 22 commits intogitpython-developers:mainfromYobmod:main
Jul 19, 2021

Conversation

Yobmod
Copy link
Contributor

@YobmodYobmod commentedJul 19, 2021
edited
Loading

Adding types to refs module, and backtracking to make sure they agree with previous types.

I also changed the hard-coding of Traversable.list_traverse(on_edge= True) that I put in last time to be a check for it in kwargs. At the moment all it does is raise an additional deprecation warning if anyone tried to use on_edge= True - I don't think anyone would be, but better than breaking it without warning.
Also made Traversable, Serilizable and IterableObj into Protocols (typings version of abstract base classes) - shouldnt have any effect on users unless they are doing something wierd.

Added flake8-bugbear and flake8-comprehensions and fixed the (minor) complaints they had.

Removed some checks for python 3.5 in tests.

tidy up testing section
Add paragraph space
@ByronByron merged commitcfd653a intogitpython-developers:mainJul 19, 2021
@Byron
Copy link
Member

Tremendous work, thank you!

@ByronByron added this to thev3.1.19 - Bugfixes milestoneJul 23, 2021
EliahKagan added a commit to EliahKagan/GitPython that referenced this pull requestNov 4, 2023
Major changes:- Add a comment in the git.compat module above the definitions of  is_win, is_posix, and is_darwin stating that they are deprecated  and recommending that os.name (or, where applicable,  sys.platform) be used directly instead for clarity (and sometimes  accuracy).- Remove all uses of is_win and is_posix in git/ and test/,  replacing them with `os.name == "nt"` and `os.name == "posix"`,  respectively.There were no uses of is_darwin to be replaced. Although it hadbeen used at one time, the last reference to it appears to havebeen removed in4545762 (gitpython-developers#1295).This doesn't emit a DeprecationWarning when those attributes areaccessed in the git.compat module. (That might be valuable thing todo in the future, if the git.compat module is to remainnon-deprecated overall.)Two related less consequential changes are also included:- Improve ordering and grouping of imports, in modules where they  were already being changed as a result of no longer needing to  import is_<platform> (usually is_win) from git.compat.- Make minor revisions to a few comments, for readability. (This is  in addition to somewhat more substantial revisions of comments  where rewording was related to replacing uses of is_<platform>.)
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
@Yobmod@Byron

[8]ページ先頭

©2009-2025 Movatter.jp