Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork939
revert util.expand_path() due to regression#1240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Thanks for the fix! What I understand is that the try-catch block has to be entered with It's quite amazing how GitPython seems to be at a state where minor changes will break someone, somewhere, under certain situations like multi-threading. It's a little frightening too. |
Uh oh!
There was an error while loading.Please reload this page.
Hopefully tofix#1238.
The orginal change (commit39eb0e6) was attempting to get mypy consistant with expand_path(None), as it doesn't like try except blocks without some type narrowing and expanduser doesn't accept None (triggering the Exception). Added mypy ignores for now, to allow CI to pass.
It passes tests either way, so can't be sure, but the traceback points to an overload of cmd.Git.excecute(), wherein cwd = self._working_dir.
That leads to Git.init(), where self._working_dir = expand_user(working_dir)