Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

GPG signature support on commit object.#124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed

Conversation

sugi
Copy link
Contributor

@sugisugi commentedOct 7, 2013

I rewrite the patch for GPG signature support with unit test.

This replaces pull request#57 and also fixes issue#110.

@sanjayankur31
Copy link

It'll be nice to have this merged at least. GPG signed commits are good!

@curtislacy
Copy link

What's the current status on this? I've inherited some code that reports git versions of the running system, and it started breaking when we started signing our code.

@petertodd
Copy link

FWIW in addition to signed commits there are also signed tags, and further-more when you merge a signed tag recent versions of git will actually include the signed tag itself in the commit created, letting you verify that signature without the tag object itself. Not too many projects do this, but the Linux kernel git repo does.

@Marlinc
Copy link

Can someone fix this pull request?
I don't know Python so I can't.

@Byron
Copy link
Member

I just had a look at this one, and it seems it's not easily mergeable for some reason.

Also, it might not be of any use as branch 0.3 is the one most people are seeing, which will require it to be backported as well.
This pull request was made against master, which changed a lot and is currently entirely unsupported.
However, I will do this with priority, as it clearly is a useful feature with a sound implementation.

@shenek
Copy link

Hi, try to apply it from herehttp://pastebin.com/729KRw8V
The main issue was that the original code used tabs. The new one uses spaces.

(If the patch still won't apply try to add a space to the end of the last line. Pastebin removed it for some reason...)

@Byron
Copy link
Member

Thanks for the hint !
I just looked at the commandline diff, and for some reason didn't even consider whitespace issues as a possible cause, even though I was the one who applied the transition from tabs to whitespace in the first place.

mrasskazov added a commit to mrasskazov/GitPython that referenced this pull requestSep 8, 2014
Originals:Pull request "GPG signature support on commit object"gitpython-developers#124 by Tatsuki Sugiura.gitpython-developers#124commit8065d2acommit62ecd6c
@mrasskazov
Copy link
Contributor

I have rebased this pull request to current 0.3 and sent new one#189. Please review and and consider to merge.

@Byron
Copy link
Member

I will close this request, as it was already merged into 0.3. In master it is not required, as it is obsolete.
Thanks for your understanding.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

8 participants
@sugi@sanjayankur31@curtislacy@petertodd@Marlinc@Byron@shenek@mrasskazov

[8]ページ先頭

©2009-2025 Movatter.jp