Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork938
Add types to git/config.py#1234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
…eds_values() .set_dirty_and_flush_changes()
…udes() ._included_paths() .__del__() .__exit__() .__enter__() ._optionform()
… .read_only .get_value .get_values ._string_to_value ._value_to_string .add_value .rename_section
Thanks for the additional explanation - it definitely helps. My workflow is to checkout the PR and try the types locally, possibly changing some types to see what mypy thinks about that just to realize that the types presented here are the one (or only) way to make it happy. In the very first file fo the diff Maybe I can also direct your attention to#1235 in case there is a chance it might be related to typing. In any case, I will cut a release momentarily. And last but not least: Thank you for all the work you put into GitPython types! They should help making the codebase more maintainable. |
Uh oh!
There was an error while loading.Please reload this page.
Adding types to config.py and cmd.py
Functions annotated all listed in commit titles.
I had to use a few casts in this one, due to the use of hassattr to distinguish strings from file objects.
If anyone knows a better way, let me know. (Its an open issue on mypy, and Guido recomends rewriting and doing type checks - a job for the future!)python/mypy#1424 (comment)
Some minor logic changes, all for type checks (e.g. because str is a subtype of Sequence, have to check for it before other sequences) or to try to separate strings from bytes.
All check pass and mypy happy. I also ran some basic scripts against it, and no errors.
Might be worth cutting a release after this PR, in case an errors are hiding?
(No rush, I only submitted this one so fast as it was waiting in my fork already)