Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Fix missing stderr when the progress parameter of _clone is None#1224

Merged
Byron merged 3 commits intogitpython-developers:mainfrom
liangjingyang:fix-missing-stderr
Apr 22, 2021
Merged

Fix missing stderr when the progress parameter of _clone is None#1224
Byron merged 3 commits intogitpython-developers:mainfrom
liangjingyang:fix-missing-stderr

Conversation

@liangjingyang
Copy link
Contributor

Try tofix#1221

Theto_progress_instance function will convertNone toRemoteProgress instance, so the lineif progress_checked is True ifprogress parameter isNone.

Copy link
Contributor

@muggenhormuggenhor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks for finding this! I've created a unit test that fails without and succeeds with this change (also withonly the the condition change as I suggested).

@Byron
Copy link
Member

Thanks for finding this! I've created a unit test that fails without and succeeds with this change (also withonly the the condition change as I suggested).

Are you able to push it into this PR? If not I would be happy to do that for you if you post it here.

@Byron
Copy link
Member

Once approved by@muggenhor this one should be ready to merge. Looks good to me (as the tests are green :) even though without the fix they are not).

@ByronByron merged commitb85fec1 intogitpython-developers:mainApr 22, 2021
@ByronByron added this to thev3.1.16 - Bugfixes milestoneApr 22, 2021
@ByronByron mentioned this pull requestApr 22, 2021
3 tasks
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

1 more reviewer

@muggenhormuggenhormuggenhor approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Development

Successfully merging this pull request may close these issues.

GitCommand missing stderr

3 participants

@liangjingyang@Byron@muggenhor
[8]ページ先頭
©2009-2026 Movatter.jp