Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Drop python 3.4, prep for adding types#1188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
Byron merged 7 commits intogitpython-developers:masterfromYobmod:main
Mar 3, 2021
Merged

Drop python 3.4, prep for adding types#1188

Byron merged 7 commits intogitpython-developers:masterfromYobmod:main
Mar 3, 2021

Conversation

Yobmod
Copy link
Contributor

@YobmodYobmod commentedFeb 28, 2021•
edited
Loading

  • Drop python 3.4 in setup.py and tox.ini
  • Update .gitnignore
  • Add mypy.ini
  • Add git/py.typed file and to setup.py
  • add test/testrunner.py as a hook for monkeytype
  • Add git/types.py for type aliases and classes
  • (Some commits just formatting. VSCode switched my flake8 off for mypy)

@Yobmod
Copy link
ContributorAuthor

I've had to rename testrunner.py as it was interferring with the checks. Feel free to change to a better name!

@Byron
Copy link
Member

Thanks a lot! Please let me know if this is a draft (and I will make it a draft PR) or when it's ready to be merged as foundation for types (I really don't know much anything about that and rely solely on your expertise, thanks in advance for bearing my ignorance 😅).

@Yobmod
Copy link
ContributorAuthor

Yobmod commentedMar 2, 2021•
edited
Loading

I think this is ready to merge as is.
It doesn't touch any of the existing code (except setup.py), but gets it all ready for adding types, whichever route we end up going for that.

Byron reacted with thumbs up emoji

@ByronByron merged commit20f4a9d intogitpython-developers:masterMar 3, 2021
@Byron
Copy link
Member

Thanks a lot, I am looking forward to seeing the first types :)!

EliahKagan added a commit to EliahKagan/GitPython that referenced this pull requestOct 23, 2023
It benefits from a docstring because it is not referenced in codeor documentation, and its purpose is/was otherwise unclear.The docstring includes a reference togitpython-developers#1188 for more information.
EliahKagan added a commit to EliahKagan/GitPython that referenced this pull requestOct 23, 2023
It benefits from a docstring because it is not referenced in codeor documentation, and its purpose is/was otherwise unclear.The docstring includes a reference togitpython-developers#1188 for more information.
EliahKagan added a commit to EliahKagan/GitPython that referenced this pull requestOct 23, 2023
It benefits from a docstring because it is not referenced in codeor documentation, and its purpose is/was otherwise unclear.The docstring includes a reference togitpython-developers#1188 for more information.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@Yobmod@Byron
[8]ページ先頭
©2009-2025 Movatter.jp