Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Fixed broken paths in tutorial documentation#1033

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
Byron merged 1 commit intogitpython-developers:masterfromkiancross:fix-doc-examples
Jul 13, 2020
Merged

Fixed broken paths in tutorial documentation#1033

Byron merged 1 commit intogitpython-developers:masterfromkiancross:fix-doc-examples
Jul 13, 2020

Conversation

kiancross
Copy link
Contributor

PR for#1032
Fix for bug introduced in#1031.

@kiancross
Copy link
ContributorAuthor

Warnings should probably be treated as errors when building the documentation (including a non-existent file is a warning not an error). This would then have been caught by the GitHub action which builds the documentation. However, the other superfluous warnings being produced by Sphinx would need to be sorted first.

Byron reacted with thumbs up emoji

@ByronByron merged commita3ea6c0 intogitpython-developers:masterJul 13, 2020
@Byron
Copy link
Member

Thanks a lot for helping to fix this one!
So many places where releases can go wrong, and thus far GitPython was just pretty lucky.

I agree, it would be great to have sphinx fail instead of ignoring warnings - and I wonder if one could keep only the warnings that are known to be errors, instead of having to fix all the other warnings, in case that get's us to having at least some test earlier.

On the other hand, maybe now we are stable once again so we are good for the years to come.

It seems likelatest is now back, but another release is required to fix stable.
Why not :D.

kiancross reacted with thumbs up emoji

@ByronByron added this to thev3.1.6 - Bugfixes milestoneJul 13, 2020
@kiancrosskiancross deleted the fix-doc-examples branchJuly 13, 2020 13:07
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
@kiancross@Byron

[8]ページ先頭

©2009-2025 Movatter.jp