Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork939
[RFC/WIP] move tests and avoid packaging them#1031
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This should ensure that tests are NOT packaged intorelease package by setuptools, as tests are developmentonly+ fixtures after movingSigned-off-by: Konrad Weihmann <kweihmann@outlook.com>
by using exclude feature of find_packages.py_modules are determined by new function, whichrecursively scans the base dir but omits theexternal modules.Plus remove now obselete package_data settingSigned-off-by: Konrad Weihmann <kweihmann@outlook.com>
and remove all previously used test related settingsSigned-off-by: Konrad Weihmann <kweihmann@outlook.com>
Signed-off-by: Konrad Weihmann <kweihmann@outlook.com>
which installs the current codebase in a venvand runs 'import git' to test if codebase can beinstalled properly.This adds virtualenv to the test requirementsSigned-off-by: Konrad Weihmann <kweihmann@outlook.com>
Thanks a lot for giving it another go, and for 'the test' which will probably save many people a lot of time in future by catching bad releases before they happen. I will cut a new release, fingers crossed! PS: This PR is probably worth ~15GB in saved transfer volume per month ifthese stats can be trusted - amazing! |
Uh oh!
There was an error while loading.Please reload this page.
This is the followup to#1028.
Move test files out of git module and into the root dir.
This enables it to ignore them while setuptools packaging and is resulting in a way smaller release package.
additionally a new test is added, which tests package installation, to avoid ModuleNotFound errors (e.g.#1030) in future
Please review and test locally if possible - that's why I marked it as RFC/WIP for now