Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork966
[RFC/WIP] move tests and avoid packaging them#1031
Merged
Byron merged 5 commits intogitpython-developers:masterfromJul 13, 2020
priv-kweihmann:move-test-2nd
Merged
[RFC/WIP] move tests and avoid packaging them#1031Byron merged 5 commits intogitpython-developers:masterfrompriv-kweihmann:move-test-2nd
Byron merged 5 commits intogitpython-developers:masterfrom
priv-kweihmann:move-test-2nd
Conversation
This should ensure that tests are NOT packaged intorelease package by setuptools, as tests are developmentonly+ fixtures after movingSigned-off-by: Konrad Weihmann <kweihmann@outlook.com>
by using exclude feature of find_packages.py_modules are determined by new function, whichrecursively scans the base dir but omits theexternal modules.Plus remove now obselete package_data settingSigned-off-by: Konrad Weihmann <kweihmann@outlook.com>
and remove all previously used test related settingsSigned-off-by: Konrad Weihmann <kweihmann@outlook.com>
Signed-off-by: Konrad Weihmann <kweihmann@outlook.com>
which installs the current codebase in a venvand runs 'import git' to test if codebase can beinstalled properly.This adds virtualenv to the test requirementsSigned-off-by: Konrad Weihmann <kweihmann@outlook.com>
Member
Byron commentedJul 13, 2020
Thanks a lot for giving it another go, and for 'the test' which will probably save many people a lot of time in future by catching bad releases before they happen. I will cut a new release, fingers crossed! PS: This PR is probably worth ~15GB in saved transfer volume per month ifthese stats can be trusted - amazing! |
This was referencedJul 13, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
This is the followup to#1028.
Move test files out of git module and into the root dir.
This enables it to ignore them while setuptools packaging and is resulting in a way smaller release package.
additionally a new test is added, which tests package installation, to avoid ModuleNotFound errors (e.g.#1030) in future
Please review and test locally if possible - that's why I marked it as RFC/WIP for now