Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork961
Closed
Labels
Milestone
Description
The change in commit79c99c0 specifies theerrors argument ofdecode() as a keyword argument. Support for keyword arguments indecode() was added only in Python 2.7. This causes this code to raise:
TypeError: decode() takes no keyword argumentson Python 2.6.
This occurs for example on line 2297 ofthis Travis run.
Specifying theerrors argument in thedecode() invocations ingit/objects/commit.py as a positional argument resolves this. For example, line 504 is currently:
parse_actor_and_date(author_line.decode(self.encoding, errors='replace'))and should be, to resolve this:
parse_actor_and_date(author_line.decode(self.encoding, 'replace'))This applies to the three places that were changed by commit79c99c0.
I verified that the proposed change works on Python 2.6, 2.7, 3.4, 3.5.