Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork938
Closed
Labels
Milestone

Description
I noticed that starting with GitPython 0.3.4 hexadecimal SHAs are no longerstr
s butunicode
s. Since the expected type is not documented anywhere (assuming that changelog is not a documentation), users have to guess. A wrong guess may lead to errors in programs. E.g. GitPython 0.3.4 + Python 2.7:
>>>commit.hexsha+'\xc5\x99'Traceback (mostrecentcalllast):File"<stdin>",line1,in<module>UnicodeDecodeError:'ascii'codeccan'tdecodebyte0xc5inposition0:ordinalnotinrange(128)
...this used to work before GitPython 0.3.4. This change also complicated writing programs that needs to be compatible with both GitPython < 0.3.4 and GitPython >= 0.3.4.