Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork938
Closed
Labels
Description
WithGitPython==3.1.42
one can observe following annotation ofparent_commits
argument toIndexFile.commit
([1]):
...parent_commits: Union[Commit_ish, None] = None,...
which is obviously not correct, because that argument just passed unmodified downwards toCommit.create_from_tree
, which has following annotation instead ([2]):
parent_commits: Union[None, List["Commit"]] = None
That leads to nasty Mypy warnings when one's trying to useIndexFile.commit
with anything different thanNone
.
[1] -https://github.com/gitpython-developers/GitPython/blob/3.1.42/git/index/base.py#L1080
[2] -https://github.com/gitpython-developers/GitPython/blob/3.1.42/git/objects/commit.py#L506