Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork938
Description
Somewhat similar to#1845, thegit.db.GitCmdObjectDB
docstring contains this note:
Lines 34 to 35 in87b8035
:note: For now, we use the git command to do all the lookup, just until we | |
have packs and the other implementations. |
I think that note can simply be removed now, since as far as I know, it does not correspond to a current goal and is not needed to understand the code or how to use it. But I am not confident of this, because I am not sure exactlywhat it is actually referring to. If more features were implemented, would this have been:
- A change to
GitCmdObjectDB
itself? - Switching back from
GitCmdObjectDB
toGitDB
? - A combination of the two, or something else related?
That only needs to be answered if it affects what should happen in that docstring (or elsewhere), which is why I've made this an issue rather than a discussion question.
I plan to remove it in a forthcoming PR with a number of other docstring revisions, but I'm opening this in case my understanding is mistaken.