Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

"make [force_]release" attempts upload even if build fails #1660

Closed
@EliahKagan

Description

@EliahKagan

Theforce_release target inMakefile (which is also used by therelease target after it attempts to check some things separate from this issue) had previously stopped after a failed attempt to build. But since#1654 it runstwine to attempt the upload whether or not the build succeeded.

The problem is that a command of the forma || b succeeds whena succeeds, but also whena fails butb succeeds:

python3 -m build --sdist --wheel||echo"Use a virtual-env with 'python -m venv env && source env/bin/activate' instead"

So that command fails only in the rare case thatecho fails to write to standard output.

But the message about how using a virtual environment may remedy a build failure is valuable and should not be removed. Instead, the logic can be adjusted to make sure the command fails if it gets that far.

There are some other improvements I'd like to propose toMakefile, and I think it will be convenient to include a fix for this with them. But I wanted to open an issue for this, because I think this behavior is unexpected and could cause confusion while making a release if it is not anticipated (if the next release is made before it is fixed and something keeps the build command from succeeding).

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions


      [8]ページ先頭

      ©2009-2025 Movatter.jp