Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork966
Description
It’s not entirely clear how one is supposed to name GitPython’s exceptions:
- According tothe API reference, they live in the
git.excmodule. - In
__init__.py, the very first line doesfrom git.exp import *, meaning they can actually just be referenced in thegitmodule instead if one wishes (is that intentional/public knowledge?).
Then, further down__init__.py, there are two places whereexcept Something as exc is done in module-level code. While those won’t execute on success (and will prevent the module from importing on failure), they do confuse Pylint: if I try toexcept git.exc.InvalidGitRepositoryError in my own code and then lint it, Pylint complains thatInstance of 'GitError' has no 'InvalidGitRepositoryError' member, because it believes the namegit.exc itself might actually be an instance ofGitError (as it would be ifthisexcept clause were taken).
Is it intended that we refer to exception classes fromgit rather thangit.exc? If so, could the documentation be updated? If not—if we are not supposed to know about thefrom git.exc import *—could the variable names used in thoseexcept blocks be modified to not collide with a submodule name?