Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork938
Closed
Labels
Milestone
Description
Hello,
Due to a change made in Git to address a security vulnerability, some tests are failing.
See here for a description of the change:
https://github.blog/2022-10-18-git-security-vulnerabilities-announced/#cve-2022-39253
These are the failing tests:
- test_list_only_valid_submodules
- test_git_submodules_and_add_sm_with_new_commit
The fail signature is the same in both cases:
cmdline: git submodule add /[redacted]/GitPython/git/ext/gitdb/gitdb/ext/smmap modulestderr: 'Cloning into '/tmp/test_list_only_valid_submoduleshv3nprno/parent/module'...fatal: transport 'file' not allowedfatal: clone of '/[redacted]/GitPython/git/ext/gitdb/gitdb/ext/smmap' into submodule path '/tmp/test_list_only_valid_submoduleshv3nprno/parent/module' failed'Here is a blog post discussing this issue affecting others:
I have fixed this locally by changing the submodule add command in each test from:
repo.git.submodule("add", self._small_repo_url(), "module")to
repo.git.submodule("add", Git.polish_url("https://github.com/gitpython-developers/smmap.git"), "module")If this is an acceptable fix I can provide it in a pull request.