Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork938
Description
Hello everyone,
I am using GitPython in my project and I use Pylance/mypy with the strict type checking settings. This setting is pretty important for my project's sanity.
As I've been using methods from GitPython that make uses of paths, I've been getting the following errors:
As you can notice, what raises this error isPathLike[Unknown]
, defined ingit.types.PathLike
. (Source file & lines)
After further investigation, I've found out that this is becauseos.PathLike
is considered as a generic class (Liketyping.List
,typing.Dict
and so on)
The fix is fairly simple, as it is to simply allowstr
forPathLike
, which gives this result:os.PathLike[str]
(awesome! This issue's no longer a thing with this fix!)
There has some discussion about the same situation on this StackOverflow page:https://stackoverflow.com/a/69680089/13720113
I can make a PR for fixing this (Of course, with some testing, since there is Python version checks), as long as this issue is approved.
Thank you, hoping this issue get sorted soon!