Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork938
Description
It'd be nice to have a method or hook where one could define clean-up actions on a RemoteProgress indicator. Theupdate()
method allows one to update progress info, but there's no way to know when a RemoteProgress indicator completes. I'm envisioning acomplete()
method on aRemoteProgress
instance that would be implemented by childclasses that GitPython would call once an action that takes a progress indicator completes.
Think for example a progress indicator that after the operation has completed spits out a "progress complete" message. Right now I do that by passing the RemoteProgress instance toclone_from
and then after theclone_from
call comes back I do a separate update to indicate operation complete. This is fine for basic sequential (ie multiple line) output to stdout, but say if you want to use a library that does progress bars (ex:Enlighten oralive-progress) that updates the same line in the terminal window, suddenly it gets a bit awkward as "ownership" of that line on screen is shared between the caller ofclone_from
and theRemoteProgress
instance.