Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork939
-
Hi@Byron , I am working on fixing theCVE-2022-24439 on our source code. Our product is currently having python3-git with 3.1.27 version. As I got to know that#1521 PR is fixing theCVE-2022-24439 so, started backporting the patches. But, after applying patches observed that in our python3-git source code there is no "test/" directory available and due to which patches are failing to apply. Later on found that there no test/ directory in original tarball downloaded from thishttps://files.pythonhosted.org/packages/source/G/GitPython/GitPython-3.1.27.tar.gz Could you please tell me if I can ignore the changes in test/ directory & apply the patches then, will it fix theCVE-2022-24439 issue ? If not then how to fix thisCVE-2022-24439 in this source code where test/ directory is not at available ? Thanks. |
BetaWas this translation helpful?Give feedback.
All reactions
You should be good ignoring the changes to tests, make also sure to apply the changes from#1518.
Replies: 1 comment 7 replies
-
You should be good ignoring the changes to tests, make also sure to apply the changes from#1518. |
BetaWas this translation helpful?Give feedback.
All reactions
-
@stsewd Could you please check these patches & confirm if these patches will be able to fix theCVE-2022-24439 ? |
BetaWas this translation helpful?Give feedback.
All reactions
-
Hi there, I've been busy, took a quick look and patches look okay. |
BetaWas this translation helpful?Give feedback.
All reactions
👍 1
-
BetaWas this translation helpful?Give feedback.
All reactions
-
@nrpt-m - In line 294 of your PR1521 patch I think there's an indentation error (breaking line 700 of remote.py): the "url = Git.polish_url(url)" is indented one space too far. Noticed this over in yocto/poky where the patches have been recently merged into Kirkstone. Will you follow up there or should I? |
BetaWas this translation helpful?Give feedback.
All reactions
-
@philsuth, Thanks for your sharp observations. It would be great help if you could follow up there. |
BetaWas this translation helpful?Give feedback.