Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork938
PermalinkChoose a base ref {{ refName }}default Choose a head ref {{ refName }}default
Comparing changes
Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also orlearn more about diff comparisons.
Open a pull request
Create a new pull request by comparing changes across two branches. If you need to, you can also.Learn more about diff comparisons here.
base repository:gitpython-developers/GitPython
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
Uh oh!
There was an error while loading.Please reload this page.
base:3.1.38
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}defaultLoading
...
head repository:gitpython-developers/GitPython
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
Uh oh!
There was an error while loading.Please reload this page.
compare:3.1.40
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}defaultLoading
- 6commits
- 6files changed
- 2contributors
Commits on Oct 18, 2023
Add missing info in Submodule.remove docstring
This rewords and adds some missing information to the docstring ofSubmodule.remove, for the "method" parameter, discussed in#1712.It uses the second suggestion presented in that issue, formattedin the style of the surrounding docstring (an 88-column wrap).It also does some other rewording in that docstring, for clarity,at the end of that same section (on the "method" parameter), and asmall punctuation fix in the section about the "force" parameter.
EliahKagan committedOct 18, 2023 Don't pre-clone submodules on CI, at least for now
This has actions/checkout no longer automatically clone submodulesin the CI test workflows. This change is for the purpose ofreproducing#1713, to allow the forthcoming fix for it to betested.However, continuing to rely on init-tests-after-clone.sh to get thesubmodules would serve as a kind of regression testing for#1713.So it is unclear at this time if and when this change should beundone.
EliahKagan committedOct 18, 2023 Have init script clone submodules unconditionally
Since7110bf8 (in#1693), "git submodule update --init --recursive"was not run on CI, on the mistaken grounds that the CI testworkflows would already have taken care of cloning all submodules(ever since4eef3ec when the "submodules: recursive" option wasadded to the actions/checkout step).This changes the init-tests-after-clone.sh script to again run thatcommand unconditionally, including on CI. The assumption that itwasn't needed on CI was based on the specific content ofGitPython's own GitHub Actions workflows. But this disregarded thatthe test suite is run on CI for *other* projects: specifically, fordownstream projects that package GitPython (#1713).This also brings back the comment fromfc96980 that says more abouthow the tests rely on submodules being present (specifically, thatthey need a submodule with a submodule). However, that is notspecifically related to the bug being fixed.
EliahKagan committedOct 18, 2023 Merge pull request#1714from EliahKagan/docstring-submodule-remove
Add missing info in Submodule.remove docstring
Byron authoredOct 18, 2023 Merge pull request#1715from EliahKagan/ci-submodules
Have init script clone submodules unconditionally
Byron authoredOct 18, 2023 - Byron committed
Oct 18, 2023
Loading
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:git diff 3.1.38...3.1.40
Uh oh!
There was an error while loading.Please reload this page.