Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork938
PermalinkChoose a base ref {{ refName }}default Choose a head ref {{ refName }}default
Comparing changes
Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also orlearn more about diff comparisons.
Open a pull request
Create a new pull request by comparing changes across two branches. If you need to, you can also.Learn more about diff comparisons here.
base repository:gitpython-developers/GitPython
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
Uh oh!
There was an error while loading.Please reload this page.
base:3.1.33
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}defaultLoading
...
head repository:gitpython-developers/GitPython
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
Uh oh!
There was an error while loading.Please reload this page.
compare:3.1.34
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}defaultLoading
- 4commits
- 4files changed
- 2contributors
Commits on Sep 2, 2023
util: close lockfile after opening successfully
Otherwise, this will leak file handles and can be a problem in Windows.Also, `closefd=true` is the default here, so need to pass it explicitly.Regression from#1619.I noticed after [our tests started raising `ResourceWarning`][1].```pythonTraceback (most recent call last): File "/opt/hostedtoolcache/Python/3.8.17/x64/lib/python3.8/site-packages/git/util.py", line 938, in _obtain_lock_or_raise open(lock_file, mode='w', closefd=True)ResourceWarning: unclosed file <_io.TextIOWrapper name='/tmp/pytest-of-runner/pytest-0/popen-gw0/external0/project.git/.git/config.lock' mode='w' encoding='UTF-8'>```[1]:https://github.com/iterative/dvc/actions/runs/6055520480/job/16434544764#step:6:869
skshetry committedSep 2, 2023 Merge pull request#1639from skshetry/close-lockfile
util: close lockfile after opening successfully
Byron authoredSep 2, 2023 - Byron committed
Sep 2, 2023
Loading
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:git diff 3.1.33...3.1.34
Uh oh!
There was an error while loading.Please reload this page.