Commitfc02230

committed

Report encoding error in test_add_unicode as error

This makes the test explicitly error out, rather than skipping, ifit appears the environment doesn't support encoding Unicodefilenames. Platforms these days should be capable of that, andreporting it as an error lessens the risk of missing a bug in thetest code (that method or a fixture) if one is ever introduced.Erroring out will also make it easier to see the details in thechained UnicodeDecodeError exception.This does not affect the behavior of GitPython itself. It onlychanges how a test reports an unusual condition that keeps the test\from being usefully run.

1 parentc6a586a commitfc02230Copy full SHA for fc02230

File tree

1 file changed

-2

lines changed

test
- test_base.py

1 file changed

-2

lines changed

`‎test/test_base.py`

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -7,7 +7,7 @@`
`7`	`7`	`importos`
`8`	`8`	`importsys`
`9`	`9`	`importtempfile`
`10`		`-fromunittestimportSkipTest,skipIf`
	`10`	`+fromunittestimportskipIf`
`11`	`11`
`12`	`12`	`fromgitimportRepo`
`13`	`13`	`fromgit.objectsimportBlob,Tree,Commit,TagObject`
`@@ -126,7 +126,7 @@ def test_add_unicode(self, rw_repo):`
`126`	`126`	`try:`
`127`	`127`	`file_path.encode(sys.getfilesystemencoding())`
`128`	`128`	`exceptUnicodeEncodeErrorase:`
`129`		`-raiseSkipTest("Environment doesn't support unicode filenames")frome`
	`129`	`+raiseRuntimeError("Environment doesn't support unicode filenames")frome`
`130`	`130`
`131`	`131`	`withopen(file_path,"wb")asfp:`
`132`	`132`	`fp.write(b"something")`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Commitfc02230

File tree

1 file changed

1 file changed

`‎test/test_base.py`

0 commit comments