Commitfad63e8

authored

Merge pull request#667 from yarikoptic/bf-useget

BF: use get, not casting get_value while dealing with submodule path/url etc

2 parentscf8dc25 +52912b5 commitfad63e8Copy full SHA for fad63e8

File tree

-5

lines changed

-5

lines changed

Lines changed: 5 additions & 5 deletions

Original file line number	Diff line number	Diff line change
`@@ -123,12 +123,12 @@ def _set_cache_(self, attr):`
`123`	`123`	`reader=self.config_reader()`
`124`	`124`	`# default submodule values`
`125`	`125`	`try:`
`126`		`-self.path=reader.get_value('path')`
	`126`	`+self.path=reader.get('path')`
`127`	`127`	`exceptcp.NoSectionError:`
`128`	`128`	`raiseValueError("This submodule instance does not exist anymore in '%s' file"`
`129`	`129`	`%osp.join(self.repo.working_tree_dir,'.gitmodules'))`
`130`	`130`	`# end`
`131`		`-self._url=reader.get_value('url')`
	`131`	`+self._url=reader.get('url')`
`132`	`132`	`# git-python extension values - optional`
`133`	`133`	`self._branch_path=reader.get_value(self.k_head_option,git.Head.to_full_path(self.k_head_default))`
`134`	`134`	`elifattr=='_name':`
`@@ -1168,11 +1168,11 @@ def iter_items(cls, repo, parent_commit='HEAD'):`
`1168`	`1168`
`1169`	`1169`	`forsmsinparser.sections():`
`1170`	`1170`	`n=sm_name(sms)`
`1171`		`-p=parser.get_value(sms,'path')`
`1172`		`-u=parser.get_value(sms,'url')`
	`1171`	`+p=parser.get(sms,'path')`
	`1172`	`+u=parser.get(sms,'url')`
`1173`	`1173`	`b=cls.k_head_default`
`1174`	`1174`	`ifparser.has_option(sms,cls.k_head_option):`
`1175`		`-b=str(parser.get_value(sms,cls.k_head_option))`
	`1175`	`+b=str(parser.get(sms,cls.k_head_option))`
`1176`	`1176`	`# END handle optional information`
`1177`	`1177`
`1178`	`1178`	`# get the binsha`

Comments

(0)