Commitefe6833

committed

Add types to config.py CONFIG_LEVELS, MetaParserBuilder.__new__() .needs_values() .set_dirty_and_flush_changes()

1 parent37cef23 commitefe6833Copy full SHA for efe6833

File tree

4 files changed

+14

-13

lines changed

git
- config.py
- repo
  - base.py
- types.py
mypy.ini

4 files changed

+14

-13

lines changed

`‎git/config.py`

Lines changed: 8 additions & 8 deletions

Original file line number	Diff line number	Diff line change
`@@ -31,9 +31,9 @@`
`31`	`31`
`32`	`32`	`# typing-------------------------------------------------------`
`33`	`33`
`34`		`-fromtypingimportTYPE_CHECKING,Tuple`
	`34`	`+fromtypingimportAny,Callable,Mapping,TYPE_CHECKING,Tuple`
`35`	`35`
`36`		`-fromgit.typesimportLiteral`
	`36`	`+fromgit.typesimportLiteral,Lit_config_levels,TBD`
`37`	`37`
`38`	`38`	`ifTYPE_CHECKING:`
`39`	`39`	`pass`
`@@ -59,7 +59,7 @@`
`59`	`59`	`classMetaParserBuilder(abc.ABCMeta):`
`60`	`60`
`61`	`61`	`"""Utlity class wrapping base-class methods into decorators that assure read-only properties"""`
`62`		`-def__new__(cls,name,bases,clsdict):`
	`62`	`+def__new__(cls,name:str,bases:TBD,clsdict:Mapping[str,Any])->TBD:`
`63`	`63`	`"""`
`64`	`64`	`Equip all base-class methods with a needs_values decorator, and all non-const methods`
`65`	`65`	`with a set_dirty_and_flush_changes decorator in addition to that."""`
`@@ -85,23 +85,23 @@ def __new__(cls, name, bases, clsdict):`
`85`	`85`	`returnnew_type`
`86`	`86`
`87`	`87`
`88`		`-defneeds_values(func):`
	`88`	`+defneeds_values(func:Callable)->Callable:`
`89`	`89`	`"""Returns method assuring we read values (on demand) before we try to access them"""`
`90`	`90`
`91`	`91`	`@wraps(func)`
`92`		`-defassure_data_present(self,args,*kwargs):`
	`92`	`+defassure_data_present(self,args:Any,*kwargs:Any)->Any:`
`93`	`93`	`self.read()`
`94`	`94`	`returnfunc(self,args,*kwargs)`
`95`	`95`	`# END wrapper method`
`96`	`96`	`returnassure_data_present`
`97`	`97`
`98`	`98`
`99`		`-defset_dirty_and_flush_changes(non_const_func):`
	`99`	`+defset_dirty_and_flush_changes(non_const_func:Callable)->Callable:`
`100`	`100`	`"""Return method that checks whether given non constant function may be called.`
`101`	`101`	`If so, the instance will be set dirty.`
`102`	`102`	`Additionally, we flush the changes right to disk"""`
`103`	`103`
`104`		`-defflush_changes(self,args,*kwargs):`
	`104`	`+defflush_changes(self,args:Any,*kwargs:Any)->Any:`
`105`	`105`	`rval=non_const_func(self,args,*kwargs)`
`106`	`106`	`self._dirty=True`
`107`	`107`	`self.write()`
`@@ -206,7 +206,7 @@ def items_all(self):`
`206`	`206`	`return [(k,self.getall(k))forkinself]`
`207`	`207`
`208`	`208`
`209`		`-defget_config_path(config_level:Literal['system','global','user','repository'])->str:`
	`209`	`+defget_config_path(config_level:Lit_config_levels)->str:`
`210`	`210`
`211`	`211`	`# we do not support an absolute path of the gitconfig on windows ,`
`212`	`212`	`# use the global config instead`

`‎git/repo/base.py`

Lines changed: 1 addition & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -34,7 +34,7 @@`
`34`	`34`
`35`	`35`	`# typing ------------------------------------------------------`
`36`	`36`
`37`		`-fromgit.typesimportTBD,PathLike,Literal`
	`37`	`+fromgit.typesimportTBD,PathLike,Lit_config_levels`
`38`	`38`	`fromtypingimport (Any,BinaryIO,Callable,Dict,`
`39`	`39`	`Iterator,List,Mapping,Optional,`
`40`	`40`	`TextIO,Tuple,Type,Union,`
`@@ -45,7 +45,6 @@`
`45`	`45`	`fromgit.refs.symbolicimportSymbolicReference`
`46`	`46`	`fromgit.objectsimportTagObject,Blob,Tree# NOQA: F401`
`47`	`47`
`48`		`-Lit_config_levels=Literal['system','global','user','repository']`
`49`	`48`
`50`	`49`	`# -----------------------------------------------------------`
`51`	`50`

`‎git/types.py`

Lines changed: 4 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -12,8 +12,6 @@`
`12`	`12`	`fromtyping_extensionsimportFinal,Literal# noqa: F401`
`13`	`13`
`14`	`14`
`15`		`-TBD=Any`
`16`		`-`
`17`	`15`	`ifsys.version_info[:2]< (3,6):`
`18`	`16`	`# os.PathLike (PEP-519) only got introduced with Python 3.6`
`19`	`17`	`PathLike=str`
`@@ -23,3 +21,7 @@`
`23`	`21`	`elifsys.version_info[:2]>= (3,9):`
`24`	`22`	`# os.PathLike only becomes subscriptable from Python 3.9 onwards`
`25`	`23`	`PathLike=Union[str,os.PathLike[str]]`
	`24`	`+`
	`25`	`+TBD=Any`
	`26`	`+`
	`27`	`+Lit_config_levels=Literal['system','global','user','repository']`

`‎mypy.ini`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -2,7 +2,7 @@`
`2`	`2`	`[mypy]`
`3`	`3`
`4`	`4`	`# TODO: enable when we've fully annotated everything`
`5`		`-#disallow_untyped_defs = True`
	`5`	`+disallow_untyped_defs = True`
`6`	`6`
`7`	`7`	`# TODO: remove when 'gitdb' is fully annotated`
`8`	`8`	`[mypy-gitdb.*]`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Commitefe6833

File tree

4 files changed

4 files changed

`‎git/config.py`

`‎git/repo/base.py`

`‎git/types.py`

`‎mypy.ini`

0 commit comments