Commitedf9fc5

committed

Git: guard against passing False to git commands

git does not accept commands of the form:git cmd --xx=Falseorgit cmd -xFalseThis patch prevents transform_kwargs from producingcommand lines with those values.This adds some flexibility/syntactic sugar for callerssince they can then assume that kwargs with a False valueare not passed to git commands.Signed-off-by: David Aguilar <davvid@gmail.com>

1 parentbf20839 commitedf9fc5Copy full SHA for edf9fc5

File tree

1 file changed

-2

lines changed

lib/git
- cmd.py

1 file changed

-2

lines changed

`‎lib/git/cmd.py`

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -132,12 +132,12 @@ def transform_kwargs(self, **kwargs):`
`132`	`132`	`iflen(k)==1:`
`133`	`133`	`ifvisTrue:`
`134`	`134`	`args.append("-%s"%k)`
`135`		`-else:`
	`135`	`+eliftype(v)isnotbool:`
`136`	`136`	`args.append("-%s%s"% (k,v))`
`137`	`137`	`else:`
`138`	`138`	`ifvisTrue:`
`139`	`139`	`args.append("--%s"%dashify(k))`
`140`		`-else:`
	`140`	`+eliftype(v)isnotbool:`
`141`	`141`	`args.append("--%s=%s"% (dashify(k),v))`
`142`	`142`	`returnargs`
`143`	`143`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Commitedf9fc5

File tree

1 file changed

1 file changed

`‎lib/git/cmd.py`

0 commit comments