Commite8343e2

committed

Firm up comment about is_win in util.is_cygwin_git

The is_cygwin_git function returns False when we have is_win,because is_win is not True on Cygwin systems. The existing commentexplained why, but was tentative. The claims are accurate, so thisrewrites the comment to state it more definitively.

1 parentcd16a35 commite8343e2Copy full SHA for e8343e2

File tree

1 file changed

-2

lines changed

git
- util.py

1 file changed

-2

lines changed

`‎git/util.py`

Lines changed: 1 addition & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -419,8 +419,7 @@ def is_cygwin_git(git_executable: PathLike) -> bool:`
`419`	`419`
`420`	`420`	`defis_cygwin_git(git_executable:Union[None,PathLike])->bool:`
`421`	`421`	`ifis_win:`
`422`		`-# is_win seems to be true only for Windows-native pythons`
`423`		`-# cygwin has os.name = posix, I think`
	`422`	`+# is_win is only True on native Windows systems. On Cygwin, os.name == "posix".`
`424`	`423`	`returnFalse`
`425`	`424`
`426`	`425`	`ifgit_executableisNone:`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Commite8343e2

File tree

1 file changed

1 file changed

`‎git/util.py`

0 commit comments