Commite54277f

committed

Compare types in test_orig_head with "is"

This performs an exact type comparison with "is" instead of "==".Most (maybe all?) of the rest of the places where "==" was usedhave been changed previously, but this on fell through the cracks.Like the None object, type objects use reference-based equalitycomparison, and the idiomatic ways to check against them are "is"for exactly comparisons and isinstance/issubclass otherwise.

1 parent86fcb1b commite54277fCopy full SHA for e54277f

File tree

1 file changed

-1

lines changed

test
- test_refs.py

1 file changed

-1

lines changed

`‎test/test_refs.py`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -207,7 +207,7 @@ def test_is_valid(self):`
`207`	`207`	`assertnotSymbolicReference(self.rorepo,"hellothere").is_valid()`
`208`	`208`
`209`	`209`	`deftest_orig_head(self):`
`210`		`-asserttype(self.rorepo.head.orig_head())==SymbolicReference`
	`210`	`+asserttype(self.rorepo.head.orig_head())isSymbolicReference`
`211`	`211`
`212`	`212`	`@with_rw_repo("0.1.6")`
`213`	`213`	`deftest_head_checkout_detached_head(self,rw_repo):`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Commite54277f

File tree

1 file changed

1 file changed

`‎test/test_refs.py`

0 commit comments