Commite4fd2e3

committed

Drop wrong variable annotations in BlobFilter.__call__

This fixes two mypy errors by removing the annotations of thefilter_parts and blob_parts local variables as lists. They onlyneed to be sequences (more precisely, they only need to be sizedand iterable, they don't even need to support subscripting in theway __call__ uses them), and mypy is able to infer their type.

1 parent4dfd480 commite4fd2e3Copy full SHA for e4fd2e3

File tree

1 file changed

-3

lines changed

git/index
- typ.py

1 file changed

-3

lines changed

`‎git/index/typ.py`

Lines changed: 3 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -12,7 +12,7 @@`
`12`	`12`
`13`	`13`	`# typing ----------------------------------------------------------------------`
`14`	`14`
`15`		`-fromtypingimportNamedTuple,Sequence,TYPE_CHECKING,Tuple,Union,cast,List`
	`15`	`+fromtypingimportNamedTuple,Sequence,TYPE_CHECKING,Tuple,Union,cast`
`16`	`16`
`17`	`17`	`fromgit.typesimportPathLike`
`18`	`18`
`@@ -60,8 +60,8 @@ def __call__(self, stage_blob: Tuple[StageType, Blob]) -> bool:`
`60`	`60`	`path:Path=pathlikeifisinstance(pathlike,Path)elsePath(pathlike)`
`61`	`61`	# TODO: Change to use `PosixPath.is_relative_to` once Python 3.8 is no
`62`	`62`	`# longer supported.`
`63`		`-filter_parts:List[str]=path.parts`
`64`		`-blob_parts:List[str]=blob_path.parts`
	`63`	`+filter_parts=path.parts`
	`64`	`+blob_parts=blob_path.parts`
`65`	`65`	`iflen(filter_parts)>len(blob_parts):`
`66`	`66`	`continue`
`67`	`67`	`ifall(i==jfori,jinzip(filter_parts,blob_parts)):`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Commite4fd2e3

File tree

1 file changed

1 file changed

`‎git/index/typ.py`

0 commit comments