Commitde3b963

committed

Moved test-centric windows specific fix into the class itself to assure this kind of issue doesn't popup for anyone

1 parent258403d commitde3b963Copy full SHA for de3b963

File tree

+11

-7

lines changed

+11

-7

lines changed

Lines changed: 11 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -25,6 +25,7 @@`
`25`	`25`	`join,`
`26`	`26`	`)`
`27`	`27`	`importre`
	`28`	`+importos`
`28`	`29`
`29`	`30`	`__all__= ('RemoteProgress','PushInfo','FetchInfo','Remote')`
`30`	`31`
`@@ -418,6 +419,16 @@ def __init__(self, repo, name):`
`418`	`419`	`self.repo=repo`
`419`	`420`	`self.name=name`
`420`	`421`
	`422`	`+ifos.name=='nt':`
	`423`	`+# some oddity: on windows, python 2.5, it for some reason does not realize`
	`424`	`+# that it has the config_writer property, but instead calls __getattr__`
	`425`	`+# which will not yield the expected results. 'pinging' the members`
	`426`	`+# with a dir call creates the config_writer property that we require`
	`427`	`+# ... bugs like these make me wonder wheter python really wants to be used`
	`428`	`+# for production. It doesn't happen on linux though.`
	`429`	`+dir(self)`
	`430`	`+# END windows special handling`
	`431`	`+`
`421`	`432`	`def__getattr__(self,attr):`
`422`	`433`	`"""Allows to call this instance like`
`423`	`434`	`remote.special( args, *kwargs) to call git-remote special self.name"""`

Lines changed: 0 additions & 7 deletions

Original file line number	Diff line number	Diff line change
`@@ -188,13 +188,6 @@ def remote_repo_creator(self):`
`188`	`188`	`d_remote.fetch()`
`189`	`189`	`remote_repo_url="git://localhost%s"%remote_repo_dir`
`190`	`190`
`191`		`-# some oddity: on windows, python 2.5, it for some reason does not realize`
`192`		`-# that it has the config_writer property, but instead calls __getattr__`
`193`		`-# which will not yield the expected results. 'pinging' the members`
`194`		`-# with a dir call creates the config_writer property that we require`
`195`		`-# ... bugs like these make me wonder wheter python really wants to be used`
`196`		`-# for production. It doesn't happen on linux though.`
`197`		`-dir(d_remote)`
`198`	`191`	`d_remote.config_writer.set('url',remote_repo_url)`
`199`	`192`
`200`	`193`	`# try to list remotes to diagnoes whether the server is up`

Comments

(0)